Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New option to compare apertures plots for pre_delivery_data #165

Open
mgennaro opened this issue Feb 9, 2021 · 0 comments
Open

New option to compare apertures plots for pre_delivery_data #165

mgennaro opened this issue Feb 9, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@mgennaro
Copy link
Contributor

mgennaro commented Feb 9, 2021

The current default for pre_delivery_data is to prepare separate plots for selected apertures from the "base" version of SIAF and the "new" (i.e. pre_delivery) version. In some cases it would be useful to have the ability to see 2 versions ("base" and "new") of the same aperture plotted on the same plot (e.g. to see the aperture move).

A simple proposed pseudo-code implementation using the aperture.plot method could be:

selected_apertures = ['aperture_1', ...'aperture_N']
for ap_name in selected_apertures:
    for siaf,siaf_name in zip([new_siaf,old_siaf],['name_new_siaf,'name_old_siaf']):
        ap = siaf.apertures[ap_name]
        ap.plot(fill=False,mark_ref=True,ax=ax)
        lines.append(ax.lines[-1])
        labels.append(siaf_name)
    
   ax.legend(lines,labels,fontsize=9,ncol=2)
@mfixstsci mfixstsci added the enhancement New feature or request label Feb 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants