Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate .gitgnore issues #264

Open
Witchblade101 opened this issue Jun 10, 2022 · 3 comments
Open

Investigate .gitgnore issues #264

Witchblade101 opened this issue Jun 10, 2022 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Witchblade101
Copy link
Collaborator

Lots of hidden files and folders were included in a recent PR, including "._" files that are explicitly included in our .gitignore file. Investigate what changes are needed to stop that from happening in the future.

Any reason to not ignore all '.' files, instead of calling out specific ones like we do now?

@Witchblade101 Witchblade101 added the bug Something isn't working label Jun 10, 2022
@Witchblade101 Witchblade101 self-assigned this Jun 10, 2022
@mgennaro
Copy link
Contributor

I note that in PRs #252 and #254 (both? one? I don't recall), I did git rm a huge bunch of NIRSpec files in the pre_delivery area, which I was indeed surprise to have to deal with

@mgennaro
Copy link
Contributor

But actually now taht I looked, the .gitignore file does NOT exclude the pre_delivery folder. Exclduing that has been my automatic behavior in the past (ie I never git add * or git add files_in_the_pre_delivery_data_folder), but someone must have done that for NIRSpec, and the thing got merged w/o removing those files from the PR.

@Witchblade101
Copy link
Collaborator Author

Deleting all of the files in pre_delivery and temporary_data is part of the release process. This is the first time we've had multiple instruments going into a release, due to all the SI commissioning going on at the same time. So nobody was starting from a clean slate, as was the usual.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants