-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix plotting commands #323
Labels
bug
Something isn't working
Comments
Tested old versions starting with 0.10.0. Plotting breaks in pysiaf starting with 0.13.0. Before that it behaves as expected. |
@mfixstsci This strongly points to my initial suspicion that the problem relates to the changes made with PR #177 and PR #185 (Since that was the only time I remember anyone touching the plot functions...) |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@tddesjardins pointed out on Slack that fillstyle='full' doesn't appear to work anymore.
The plotted apertures in the readme.md and other documentation show the defaults of aperture.plot(), which are filled cyan shapes. This appears to now be overridden almost everywhere by empty shapes with different colored lines for each aperture (see siaf.plot_main_apertures(), e.g.)
I also notice that in the default HST plotting example it appears that some ACS apertures are getting filled, but are at a different scale or on a different coordinate system.
From Readme.md:
![image](https://private-user-images.githubusercontent.com/7120558/268076957-5ec900dc-6207-4827-9144-458b5f83ae88.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3OTEwOTEsIm5iZiI6MTcyMjc5MDc5MSwicGF0aCI6Ii83MTIwNTU4LzI2ODA3Njk1Ny01ZWM5MDBkYy02MjA3LTQ4MjctOTE0NC00NThiNWY4M2FlODgucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMTY1OTUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MThhNmZlZjkwODU4MTViZjJmOTE4NWYxNGU5OWQwYTRhZWEzMGI3NTI3NGQzYTM0OWMyMGMxNGRlMTUyMDJhOSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.MAXIvzJBcN9hjqRrSOf5b8KhbkCJ5sqzO_6qVRsEf6s)
What you currently get if you actually run that code:
![image](https://private-user-images.githubusercontent.com/7120558/268077666-1c64da7e-7c70-4bc5-b83d-1e137d8abb69.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjI3OTEwOTEsIm5iZiI6MTcyMjc5MDc5MSwicGF0aCI6Ii83MTIwNTU4LzI2ODA3NzY2Ni0xYzY0ZGE3ZS03YzcwLTRiYzUtYjgzZC0xZTEzN2Q4YWJiNjkucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgwNCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MDRUMTY1OTUxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZjYzNzIxODM4NzBkODkxNDc1MzAzNGE4NjA0MzQxZDg1ZTlhMTg1ZTBhODU3YWI5ODFjNWIyYzgxOWQ5NGEzMiZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.OPMMGhMyDo_J4HzceK_cWy9n3ZrHX-gb58rqo3qI0xw)
First step when I have the time: Find the PR or commit when this stopped working.
The text was updated successfully, but these errors were encountered: