Skip to content

Commit

Permalink
JP-3463: Add average dark current to dark models and ramp model (#265)
Browse files Browse the repository at this point in the history
  • Loading branch information
tapastro authored Feb 22, 2024
2 parents e8a8f9e + 4d7c3a6 commit e91f81f
Show file tree
Hide file tree
Showing 5 changed files with 40 additions and 0 deletions.
3 changes: 3 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,9 @@ Other
- Add ``grating`` keyword to JWST ``barshadow`` ref file schema to match
parkeys on crds [#260]

- Add ``average_dark_current`` in both scalar keyword and array extension
options to ``DarkModel`` and ``MIRIDarkModel``. Add the array extension
to the ``RampModel``, for tracking the average dark current. [#265]

1.9.1 (2024-01-25)
==================
Expand Down
7 changes: 7 additions & 0 deletions src/stdatamodels/jwst/datamodels/schemas/dark.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ allOf:
- $ref: keyword_groupgap.schema
- $ref: keyword_gainfact.schema
- $ref: keyword_psubarray.schema
- $ref: keyword_darkcurrent.schema
- $ref: subarray.schema
- type: object
properties:
Expand All @@ -35,4 +36,10 @@ allOf:
default: 0.0
ndim: 3
datatype: float32
average_dark_current:
title: Average dark current
fits_hdu: AVDRKCUR
default: 0.0
ndim: 2
datatype: float32
- $ref: dq_def.schema
7 changes: 7 additions & 0 deletions src/stdatamodels/jwst/datamodels/schemas/darkMIRI.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ allOf:
- $ref: keyword_nframes.schema
- $ref: keyword_ngroups.schema
- $ref: keyword_groupgap.schema
- $ref: keyword_darkcurrent.schema
- $ref: subarray.schema
- type: object
properties:
Expand All @@ -32,4 +33,10 @@ allOf:
default: 0.0
ndim: 4
datatype: float32
average_dark_current:
title: Average dark current
fits_hdu: AVDRKCUR
default: 0.0
ndim: 2
datatype: float32
- $ref: dq_def.schema
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
%YAML 1.1
---
$schema: "http://stsci.edu/schemas/fits-schema/fits-schema"
id: "http://stsci.edu/schemas/jwst_datamodel/keyword_darkcurrent.schema"
type: object
properties:
meta:
type: object
properties:
exposure:
type: object
properties:
average_dark_current:
title: Average dark current
type: number
default: 0.0
fits_keyword: AVDRKCUR
6 changes: 6 additions & 0 deletions src/stdatamodels/jwst/datamodels/schemas/ramp.schema.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ allOf:
default: 0.0
ndim: 4
datatype: float32
average_dark_current:
title: Average dark current
fits_hdu: AVDRKCUR
default: 0.0
ndim: 2
datatype: float32
- $ref: group.schema
- $ref: int_times.schema
- $ref: msatargacq.schema

0 comments on commit e91f81f

Please sign in to comment.