Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boot and partition info is duplicated and not part of CI #452

Closed
gdt opened this issue May 2, 2023 · 1 comment
Closed

boot and partition info is duplicated and not part of CI #452

gdt opened this issue May 2, 2023 · 1 comment

Comments

@gdt
Copy link
Contributor

gdt commented May 2, 2023

While debugging a problem (new esptool and RTK_Surveyor do not getalong, #451) , I found multiple copies of the bootloader and partition code:

./SparkFun_RTK_Firmware_Binaries/bin/boot_app0.bin
./SparkFun_RTK_Firmware_Binaries/bin/RTK_Surveyor.ino.bootloader.bin
./SparkFun_RTK_Firmware_Binaries/bin/RTK_Surveyor_Partitions_4MB.bin
./SparkFun_RTK_Firmware_Binaries/bin/RTK_Surveyor_Partitions_16MB.bin
./SparkFun_RTK_Firmware_Uploader/RTK_Firmware_Uploader/resource/boot_app0.bin
./SparkFun_RTK_Firmware_Uploader/RTK_Firmware_Uploader/resource/RTK_Surveyor.ino.bootloader.bin
./SparkFun_RTK_Firmware_Uploader/RTK_Firmware_Uploader/resource/RTK_Surveyor_Partitions_4MB.bin
./SparkFun_RTK_Firmware_Uploader/RTK_Firmware_Uploader/resource/RTK_Surveyor_Partitions_16MB.bin

Ideally, there would only be one copy. But really, these are, I think, binaries built as part of the firmware build process, and thus there would be no copies in git, and the build artifacts would have not only firmware, but the .bin files.

(I realize this is the software engineering view, and perhaps not the firmware world view.)

nseidle added a commit to sparkfun/SparkFun_RTK_Firmware_Binaries that referenced this issue May 5, 2023
@nseidle
Copy link
Member

nseidle commented May 5, 2023

Partition files removed from SparkFun_RTK_Firmware_Binaries repo.

@nseidle nseidle closed this as completed May 5, 2023
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants