Pagination on v5.0..0

[sidneyrmedeiros]

How do I paginate the result in v5.0.0?
I saw that to paginate I need to inform the limit and the offset. But I can only inform the limit.

Pagination on Google Analytics

AnalyticsClient.php

public function get(
        string $propertyId,
        Period $period,
        array $metrics,
        array $dimensions = [],
        int $maxResults = 10,
        array $orderBy = [],
    ): Collection {
        $typeCaster = resolve(TypeCaster::class);

        $response = $this->runReport([
            'property' => "properties/{$propertyId}",
            'dateRanges' => [
                $period->toDateRange(),
            ],
            'metrics' => $this->getFormattedMetrics($metrics),
            'dimensions' => $this->getFormattedDimensions($dimensions),
            'limit' => $maxResults,
            'orderBys' => $orderBy,
        ]);
#
#
#
}
    
    ```

[freekmurze]

@timvandijck could you take a look at this one?

[timvandijck]

We'll have to extend the get method so it will accept and pass the offset. I'll have a look at it, it shouldn't be too hard.

[timvandijck]

@sidneyrmedeiros FYI: I just added this to the package: https://github.com/spatie/laravel-analytics/releases/tag/5.0.1

[sidneyrmedeiros]

@timvandijck Thanks for the quick fix! And documentation update! Great job!

[laudefe]

Hello @timvandijck !
is possible to also add AnalyticsClient.php in the function "get" the parameter "metricFilter" ?
public function get(
string $propertyId,
Period $period,
array $metrics,
array $dimensions = [],
int $maxResults = 10,
array $orderBy = [],
int $offset = 0,
?FilterExpression $dimensionFilter = null,
?FilterExpression $metricFilter= null,
bool $keepEmptyRows = false,
): Collection

Reference on Google Analytics

[timvandijck]

Sounds like a good idea, I don't currently have time to work on it though. I would be happy to accept a PR for this.

[laudefe]

Hi! i made the PR here