Skip to content

Commit

Permalink
Merge pull request #132 from lukasleitsch/stream-download-with-delimiter
Browse files Browse the repository at this point in the history
Allow delimiter in streamDownload()
  • Loading branch information
freekmurze authored Jan 20, 2023
2 parents bec8449 + 3ea60af commit bbef987
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions src/SimpleExcelWriter.php
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ public static function createWithoutBom(string $file, string $type = ''): static
);
}

public static function streamDownload(string $downloadName, string $type = '', callable $writerCallback = null): static
public static function streamDownload(string $downloadName, string $type = '', callable $writerCallback = null, ?string $delimiter = null): static
{
$simpleExcelWriter = new static($downloadName, $type);
$simpleExcelWriter = new static($downloadName, $type, $delimiter);

$writer = $simpleExcelWriter->getWriter();

Expand Down

0 comments on commit bbef987

Please sign in to comment.