From f424d275b6ddde99b94ae4ec05b22fd11a57bef2 Mon Sep 17 00:00:00 2001
From: Philipp Schaad <schaad.phil@gmail.com>
Date: Sun, 28 Jun 2020 23:25:37 +0200
Subject: [PATCH 1/3] Started adding template for jumping to source code

---
 media/sdfv_base_layout.html      | 16 ++++++++++++++++
 media/sdfv_embedded_overrides.js | 22 +++++++++++++++++++++-
 src/sdfg_viewer.ts               |  7 +++++++
 3 files changed, 44 insertions(+), 1 deletion(-)

diff --git a/media/sdfv_base_layout.html b/media/sdfv_base_layout.html
index 927e8dc..f92a9a2 100644
--- a/media/sdfv_base_layout.html
+++ b/media/sdfv_base_layout.html
@@ -55,6 +55,11 @@
                 <div id="info-title-container">
                     <h3 id="info-title"></h3>
                 </div>
+                <div id="goto-source-btn" class="hidden button">
+                    <span>
+                        Go to source
+                    </span>
+                </div>
                 <div id="info-clear-btn" class="hidden button" onclick="clear_info_box();">
                     <span>
                         Clear Info &times;
@@ -94,6 +99,17 @@ <h3 id="info-title"></h3>
             }
         });
 
+        function gotoSource(filePath, startRow, startChar, endRow, endChar) {
+            vscode.postMessage({
+                type: 'gotoSource',
+                file_path: filePath,
+                startRow: startRow,
+                startChar: startChar,
+                endRow: endRow,
+                endChar: endChar,
+            });
+        }
+
         // Resize the canvas correctly if the renderer exists. This gets
         // called whenever the body's size changes.
         function rendererSendResize() {
diff --git a/media/sdfv_embedded_overrides.js b/media/sdfv_embedded_overrides.js
index abfee35..29508df 100644
--- a/media/sdfv_embedded_overrides.js
+++ b/media/sdfv_embedded_overrides.js
@@ -37,6 +37,11 @@ function clear_info_box() {
  * @param {*} elem  The element to display info about
  */
 function fill_info_embedded(elem) {
+    const gotoSourceBtn = $('#goto-source-btn');
+    // Clear and hide the go to source button.
+    gotoSourceBtn.hide();
+    gotoSourceBtn.off('click');
+
     if (elem) {
         document.getElementById('info-title').innerText =
             elem.type() + ' ' + elem.label();
@@ -80,6 +85,21 @@ function fill_info_embedded(elem) {
             );
             if (val === null || val === '')
                 continue;
+
+            if (attr[0] === 'debuginfo') {
+                gotoSourceBtn.on('click', function() {
+                    gotoSource(
+                        attr[1].filename,
+                        attr[1].start_line,
+                        attr[1].start_column,
+                        attr[1].end_line,
+                        attr[1].end_column
+                    );
+                });
+                gotoSourceBtn.show();
+                continue;
+            }
+
             const row = $('<tr>').appendTo(attr_table_body);
             $('<th>', {
                 'class': 'key-col',
@@ -141,7 +161,7 @@ function fill_info_embedded(elem) {
             }
         }
 
-        $('#info-clear-button').show();
+        $('#info-clear-btn').show();
     } else {
         clear_info_box();
     }
diff --git a/src/sdfg_viewer.ts b/src/sdfg_viewer.ts
index 8f88f5b..e7e95bf 100644
--- a/src/sdfg_viewer.ts
+++ b/src/sdfg_viewer.ts
@@ -59,6 +59,13 @@ export class SdfgViewerProvider implements vscode.CustomTextEditorProvider {
         // Handle received messages from the webview.
         webviewPanel.webview.onDidReceiveMessage(e => {
             switch (e.type) {
+                case 'gotoSource':
+                    console.log(e.file_path);
+                    console.log(e.startRow);
+                    console.log(e.startChar);
+                    console.log(e.endRow);
+                    console.log(e.endChar);
+                    return;
             }
         });
 

From 5d5f5df7d7b3707843ac9aeb01b7f07074485fc6 Mon Sep 17 00:00:00 2001
From: Philipp Schaad <schaad.phil@gmail.com>
Date: Sun, 28 Jun 2020 23:48:59 +0200
Subject: [PATCH 2/3] Added base file handling stub

---
 src/sdfg_viewer.ts | 35 ++++++++++++++++++++++++++++++-----
 1 file changed, 30 insertions(+), 5 deletions(-)

diff --git a/src/sdfg_viewer.ts b/src/sdfg_viewer.ts
index e7e95bf..e6b4616 100644
--- a/src/sdfg_viewer.ts
+++ b/src/sdfg_viewer.ts
@@ -60,11 +60,36 @@ export class SdfgViewerProvider implements vscode.CustomTextEditorProvider {
         webviewPanel.webview.onDidReceiveMessage(e => {
             switch (e.type) {
                 case 'gotoSource':
-                    console.log(e.file_path);
-                    console.log(e.startRow);
-                    console.log(e.startChar);
-                    console.log(e.endRow);
-                    console.log(e.endChar);
+                    if (fs.existsSync(path.normalize(
+                        vscode.workspace.rootPath + '/' + e.file_path))) {
+                        const fileUri: vscode.Uri =vscode.Uri.file(
+                            e.file_path
+                        );
+                        vscode.workspace.openTextDocument(fileUri).then(
+                            (doc: vscode.TextDocument) => {
+                                vscode.window.showTextDocument(
+                                    doc,
+                                    1,
+                                    false
+                                ).then(editor => {
+                                    const startPos = new vscode.Position(
+                                        e.startRow, e.startChar
+                                    );
+                                    const endPos = new vscode.Position(
+                                        e.endRow, e.endChar
+                                    );
+                                    const range = new vscode.Range(
+                                        startPos, endPos
+                                    );
+                                    editor.revealRange(range);
+                                });
+                            }
+                        );
+                    } else {
+                        console.log('File not found at: ' +
+                            path.normalize(
+                                vscode.workspace.rootPath + '/' + e.file_path));
+                    }
                     return;
             }
         });

From 310b8da1677761923dea7b005cecd897be1ded83 Mon Sep 17 00:00:00 2001
From: Philipp Schaad <schaad.phil@gmail.com>
Date: Mon, 29 Jun 2020 22:43:26 +0200
Subject: [PATCH 3/3] Go to source feature implemented

Polishing is still needed, e.g. a notice is necessary if the file
can't be found on disk.
---
 media/sdfv_base_layout.html      |  3 ++
 media/sdfv_embedded.css          | 16 +++++++++--
 media/sdfv_embedded_overrides.js |  1 +
 src/sdfg_viewer.ts               | 47 ++++++++++++++++----------------
 4 files changed, 40 insertions(+), 27 deletions(-)

diff --git a/media/sdfv_base_layout.html b/media/sdfv_base_layout.html
index f92a9a2..511c29b 100644
--- a/media/sdfv_base_layout.html
+++ b/media/sdfv_base_layout.html
@@ -60,6 +60,7 @@ <h3 id="info-title"></h3>
                         Go to source
                     </span>
                 </div>
+                <div class="flex-spacer"></div>
                 <div id="info-clear-btn" class="hidden button" onclick="clear_info_box();">
                     <span>
                         Clear Info &times;
@@ -99,6 +100,8 @@ <h3 id="info-title"></h3>
             }
         });
 
+        // Send a request to the extension to jump to a specific source code
+        // file and location, if it exists.
         function gotoSource(filePath, startRow, startChar, endRow, endChar) {
             vscode.postMessage({
                 type: 'gotoSource',
diff --git a/media/sdfv_embedded.css b/media/sdfv_embedded.css
index 1343465..b3f86c3 100644
--- a/media/sdfv_embedded.css
+++ b/media/sdfv_embedded.css
@@ -232,12 +232,22 @@ pre.code code {
   overflow-y: scroll;
 }
 
-#info-title-container {
-  float: left;
+#info-header {
+  display: flex;
+  flex-direction: row;
+  align-items: baseline;
+}
+
+.flex-spacer {
+  flex-grow: 1;
+}
+
+#goto-source-btn {
+  margin: 0 1rem;
 }
 
 #info-clear-btn {
-  float: right;
+  margin: 0 1rem;
 }
 
 #info-clear-btn span {
diff --git a/media/sdfv_embedded_overrides.js b/media/sdfv_embedded_overrides.js
index 29508df..8ca1607 100644
--- a/media/sdfv_embedded_overrides.js
+++ b/media/sdfv_embedded_overrides.js
@@ -28,6 +28,7 @@ function clear_info_box() {
     $('#info-contents').html('');
     $('#info-title').text('');
     $('#info-clear-btn').hide();
+    $('#goto-source-btn').hide();
 }
 
 /**
diff --git a/src/sdfg_viewer.ts b/src/sdfg_viewer.ts
index e6b4616..f1bff40 100644
--- a/src/sdfg_viewer.ts
+++ b/src/sdfg_viewer.ts
@@ -60,35 +60,34 @@ export class SdfgViewerProvider implements vscode.CustomTextEditorProvider {
         webviewPanel.webview.onDidReceiveMessage(e => {
             switch (e.type) {
                 case 'gotoSource':
-                    if (fs.existsSync(path.normalize(
-                        vscode.workspace.rootPath + '/' + e.file_path))) {
-                        const fileUri: vscode.Uri =vscode.Uri.file(
-                            e.file_path
-                        );
+                    // We want to jump to a specific file and location if it
+                    // exists.
+                    const filePath: string = path.normalize(
+                        vscode.workspace.rootPath + '/' + e.file_path
+                    );
+                    if (fs.existsSync(filePath)) {
+                        // The file exists, load it and show it in a new
+                        // editor, highlighting the indicated range.
+                        const fileUri: vscode.Uri = vscode.Uri.file(filePath);
                         vscode.workspace.openTextDocument(fileUri).then(
                             (doc: vscode.TextDocument) => {
+                                const startPos = new vscode.Position(
+                                    e.startRow, e.startChar
+                                );
+                                const endPos = new vscode.Position(
+                                    e.endRow, e.endChar
+                                );
+                                const range = new vscode.Range(
+                                    startPos, endPos
+                                );
                                 vscode.window.showTextDocument(
-                                    doc,
-                                    1,
-                                    false
-                                ).then(editor => {
-                                    const startPos = new vscode.Position(
-                                        e.startRow, e.startChar
-                                    );
-                                    const endPos = new vscode.Position(
-                                        e.endRow, e.endChar
-                                    );
-                                    const range = new vscode.Range(
-                                        startPos, endPos
-                                    );
-                                    editor.revealRange(range);
-                                });
+                                    doc, {
+                                        preview: true,
+                                        selection: range,
+                                    }
+                                );
                             }
                         );
-                    } else {
-                        console.log('File not found at: ' +
-                            path.normalize(
-                                vscode.workspace.rootPath + '/' + e.file_path));
                     }
                     return;
             }