Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

October improvements #203

Merged
merged 11 commits into from
Oct 24, 2022
Merged

October improvements #203

merged 11 commits into from
Oct 24, 2022

Conversation

phschaad
Copy link
Collaborator

@phschaad phschaad commented Oct 4, 2022

Companion PR for the webclient: spcl/dace-webclient#92

@phschaad phschaad added this to the October 2022 milestone Oct 4, 2022
@phschaad phschaad added bug Something isn't working enhancement New feature or request labels Oct 4, 2022
Cleans up the transformation list by removing the categories
"global" and "uncategorized" or hiding them.

Closes #194.
@phschaad phschaad marked this pull request as ready for review October 23, 2022 15:17
@phschaad phschaad requested a review from tbennun October 23, 2022 15:17
docstrings[ps.__name__] = ps.__doc__
pass_instance = ps()
transformations.append(pass_instance.to_json())
except NameError:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

name error and attribute error I assume

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you!

@phschaad phschaad merged commit d3b3ea8 into master Oct 24, 2022
@phschaad phschaad deleted the october_improvements branch October 24, 2022 07:01
@phschaad phschaad restored the october_improvements branch October 24, 2022 07:01
@phschaad phschaad deleted the october_improvements branch October 24, 2022 07:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment