You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Consistent formatting is important to avoid unnecessary conflicts and keep a consistent style in a shared codebase. Contribution guidelines thus kindly ask to run yapf before/when submitting a PR. However, consistent formatting isn't enforced in GHA workflows.
Given that two small PRs 12 showed formatting changes in code parts that I didn't touch, I would like to start a discussion on automatically enforcing consistent formatting as part of the GitHub Actions workflow.
I am happy to provide a PR for such a workflow early next year assuming we come to an agreement in this discussion.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Consistent formatting is important to avoid unnecessary conflicts and keep a consistent style in a shared codebase. Contribution guidelines thus kindly ask to run
yapf
before/when submitting a PR. However, consistent formatting isn't enforced in GHA workflows.Given that two small PRs 1 2 showed formatting changes in code parts that I didn't touch, I would like to start a discussion on automatically enforcing consistent formatting as part of the GitHub Actions workflow.
I am happy to provide a PR for such a workflow early next year assuming we come to an agreement in this discussion.
Footnotes
https://github.com/spcl/dace/pull/1731 ↩
https://github.com/spcl/dace/pull/1803 ↩
Beta Was this translation helpful? Give feedback.
All reactions