Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Schedule tree (1/3) #1145

Merged
merged 108 commits into from
Sep 26, 2023
Merged

Schedule tree (1/3) #1145

merged 108 commits into from
Sep 26, 2023

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Nov 8, 2022 •
edited
Loading

(re)scheduling oriented view of SDFGs.
Task list:

  • De-aliasing across nested SDFGs
    • Arrays and memlets (use compose)
    • Memlets and symbols in control flow blocks
    • Symbol assignments
      • (low-prio: think about C++ tasklets, or error out / replace if \bNAME\b is used?)
  • Normalize memlets everywhere (data / subset / other_subset)
    • Copy
      • If both exist, write as dst[dst_subset] = copy src[src_subset]
    • View
  • Dynamic map ranges (also with aliasing)
  • Ensure memlet paths are not generated twice
  • Duplicate label removal (also consider states in different SDFGs that share the same name!)
  • Make many tests
    • Irreducible CFGs
    • Memlet path types
      • same scope
      • multi-scope (3 nested maps)
      • through nested SDFG
      • differing src/dst subsets: same scope
      • differing src/dst subsets: inside map
      • offsetted
    • Nesting and (de)aliasing
      • Call nested(a[0:20], a[10:30])
      • prog(a, b), nested(b, c)
      • Composition: a[:, 1] -> b[-5:] -> c[2]
      • Control flow blocks with same variables in nested SDFGs
    • Code->code memlets
    • Dynamic map ranges
    • References
    • Naming clashes (n: m, m: n symbol mapping, different states with same name etc.)

tbennun and others added 30 commits November 8, 2022 14:37
@tbennun
Type hint
85aa33b
@tbennun
(re)scheduling-oriented view of an SDFG as a tree of control/data flo…
e2c227e 
…w constructs
@tbennun
Fix name bug with view and duplicate edge adds to the tree
3c0ad6b
@tbennun
Merge branch 'master' into schedule-tree
084d203
@tbennun
Bugfixes: add else clause, children as list
329d392
@tbennun
Remove duplicate labels
cda81e4
@tbennun
Revamp edge generation in schedule tree conversion and handle name co…
09fbf2d 
…llisions
@tbennun
Merge branch 'master' into schedule-tree
2dcaeb0
@tbennun
Refactor schedule tree passes and add an example pass
d1774a9
@tbennun
Support dynamic scope inputs
4518c34
@tbennun
Explicit dynamic scope input copy node
7949ebd
@tbennun
Merge remote-tracking branch 'origin/master' into schedule-tree
d104af8
@tbennun
Add memlet parsing and replacement functionality for inter-state edge…
adbf8fc 
… de-aliasing
@alexnick83
Started working on ScheduleTree utilities.
828eff3
@alexnick83
yapf
6896955
@alexnick83
Merge branch 'schedule-tree' of github.com:spcl/dace into schedule-tree
a3dbad8
@alexnick83
WIP: MapFission on ScheduleTree.
2a94d71
@alexnick83
Updated ScheduleTree MapFission transformation.
c1ca73c
@alexnick83
Added methos for printing Data (Scalar, Array) as Python arguments.
273da6c
@alexnick83
Minor bug (?) fixes related to parsing DaCe programs generated from S…
25ccc6b 
…cheduleTrees.
@alexnick83
Added replacement methods for ScheduleTree Copy, Library, and Tasklet…
d666e55 
… nodes.
@alexnick83
Added the alpha and beta properties to MatMul's init method.
7489e63
@alexnick83
Added methods to SDFG that generated DaCe Python signatures.
63ad7c5
@alexnick83
Updated the ScheduleTree nodes to point to the corresponding (nested)…
5ab2eb4 
… SDFG. Added methods for printing pseudo-DaCe-Python code. Updated the `as_schedule_tree` method to unsqueeze memlets and rename arrays to match the names in the top-level SDFG.
@alexnick83
Removed obsolete ScheduleTree utility methods.
c526195
@alexnick83
Added as_sdfg method and tests.
748f010
@alexnick83
Merge branch 'master' into schedule-tree
ab0686c
@alexnick83
inner_indices is a set
0f57358
@alexnick83
Empty inner_indices should be an empty set.
bed168e
@alexnick83
Added is_data_used method to assist identifying MapScope private va…
5e6ee5c 
…riables.
@tbennun tbennun removed the no-ci Do not run any CI or actions for this PR label Sep 24, 2023
@tbennun tbennun marked this pull request as ready for review September 25, 2023 00:25
@tbennun tbennun requested a review from phschaad September 25, 2023 08:17
phschaad
phschaad requested changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@phschaad phschaad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very excited about this PR, thank you! Small questions and revisions/changes, largely LGTM 🎉

dace/sdfg/replace.py Show resolved Hide resolved
dace/sdfg/nodes.py Show resolved Hide resolved
dace/sdfg/sdfg.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/treenodes.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/treenodes.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/passes.py Outdated Show resolved Hide resolved
dace/sdfg/analysis/schedule_tree/sdfg_to_tree.py Outdated Show resolved Hide resolved
dace/sdfg/memlet_utils.py Outdated Show resolved Hide resolved
tests/sdfg/memlet_utils_test.py Outdated Show resolved Hide resolved
dace/sdfg/memlet_utils.py Show resolved Hide resolved
@tbennun tbennun requested a review from phschaad September 26, 2023 15:58
@tbennun tbennun enabled auto-merge (squash) September 26, 2023 16:18
@tbennun tbennun merged commit a582261 into master Sep 26, 2023
9 checks passed
@tbennun tbennun deleted the schedule-tree branch September 28, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tbennun @phschaad @alexnick83