Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AugAssignToWCR: Support for more cases and increased test coverage #1359

Merged
merged 10 commits into from
Nov 3, 2023
Merged

AugAssignToWCR: Support for more cases and increased test coverage #1359

merged 10 commits into from
Nov 3, 2023

Conversation

lukastruemper
Copy link
Contributor

No description provided.

@lukastruemper lukastruemper requested review from tbennun and removed request for tbennun September 1, 2023 15:01
tbennun
tbennun requested changes Sep 1, 2023
View reviewed changes
Copy link
Collaborator

@tbennun tbennun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This will improve the transformation greatly. I’d reuse existing helper functions for the nesting. One of the conditions removed is not clearly handled to me.

dace/transformation/dataflow/wcr_conversion.py Show resolved Hide resolved
dace/transformation/dataflow/wcr_conversion.py Outdated Show resolved Hide resolved
tests/transformations/wcr_conversion_test.py Show resolved Hide resolved
@BenWeber42
Copy link
Contributor

What's the status of this PR?

@lukastruemper
Copy link
Contributor Author

What's the status of this PR?

Requested changes are addressed now

@lukastruemper lukastruemper changed the title AugAssignToWCR: More cases and testing AugAssignToWCR: Support for more cases and increased test coverage Oct 30, 2023
@lukastruemper lukastruemper requested a review from tbennun October 30, 2023 21:03
@BenWeber42
Copy link
Contributor

Test failure seems to be affected by #1421. I initiated a re-run of the tests.

@tbennun tbennun enabled auto-merge (squash) November 2, 2023 20:26
@tbennun tbennun merged commit 9430e87 into master Nov 3, 2023
9 checks passed
@tbennun tbennun deleted the wcr branch November 3, 2023 08:07
@lukastruemper lukastruemper restored the wcr branch November 11, 2023 00:27
@lukastruemper lukastruemper deleted the wcr branch November 24, 2023 13:33
lukastruemper added a commit that referenced this pull request Dec 2, 2023
@lukastruemper
AugAssignToWCR: Support for more cases and increased test coverage (#…
5cacfdd 
…1359)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbennun tbennun tbennun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukastruemper @BenWeber42 @tbennun