[DO NOT REVIEW] Refactor + Add assertions + Tests for offset related functions in subsets.py.
#1698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`subsets.py`. Currently it just fails with invalid index error for certain cases. Also, the methods are not documented, which is bad because their behaviour is not very consistent.
Cannot just assert it for `None` because of places like: https://github.com/spcl/dace/blob/master/dace/transformation/interstate/sdfg_nesting.py#L1081
order of a set is not specified, we should be able to handle that too (e.g., by returning from `offset_by()` a map from indices to new values, instead of just a sequence).
pratyai
changed the title
subsets.py.subsets.py.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently it just fails with invalid index error for certain cases. Also, the methods are not documented, which is bad because their behaviour is not very consistent, so we should at least have it commented on.