Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unskip unit tests and provide reasons for skipped tests #1742

Merged
merged 5 commits into from
Nov 11, 2024
Merged

Unskip unit tests and provide reasons for skipped tests #1742

merged 5 commits into from
Nov 11, 2024

Conversation

tbennun
Copy link
Collaborator

@tbennun tbennun commented Nov 9, 2024 •
edited
Loading

  • Brings back 36 tests that were skipped due to prior regressions that are now fixed.
  • Fixes codegen generating non-atomic WCR w.r.t. neighboring edges
  • Contains minor modifications that were used to unskip certain tests (e.g., use of the no-longer-existent symbol.get() method)
  • Gives valid reasons for all other skipped tests

@tbennun tbennun linked an issue Nov 9, 2024 that may be closed by this pull request
Go over skipped tests for 1.0 #1726
Closed
@tbennun tbennun marked this pull request as ready for review November 10, 2024 07:00
@tbennun tbennun requested a review from phschaad November 10, 2024 16:38
@phschaad phschaad added this pull request to the merge queue Nov 11, 2024
Merged via the queue into main with commit cb6391f Nov 11, 2024
10 checks passed
@phschaad phschaad deleted the unskip branch November 11, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phschaad phschaad phschaad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Go over skipped tests for 1.0
2 participants
@tbennun @phschaad