Fixing SDFGState._read_and_write_sets()
#1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ite_sets()`. If a subset is `None` the function assumes that corresponding array is fully accessed. Before, there was an `assert` that ensured that this assumption is true. However, the implementation also assumed that this could be verified, either because the same symbols were used or the size was known. But this if not necessarily the case, if the two involved arrays uses different symbols, that however, are always the same. The other reason was that before the size was estimated using `total_size`, which has a well defined meaning for an `Array` but in case of a `View` its meaning is not fully clear. For these reasons the asserts was removed.
However it does not work because of pow.
philip-paul-mueller
added a commit
to philip-paul-mueller/dace
that referenced
this pull request
Nov 11, 2024
However, to work we need spcl#1747.
tbennun
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed some asserts that were to strict from
SDFGState._read_and_write_sets().If a subset is
Nonethe function assumes that corresponding array is fully accessed.Before, there was an
assertthat ensured that this assumption is true.However, the implementation also assumed that this could be verified, either because the same symbols were used or the size was known.
But this if not necessarily the case, if the two involved arrays uses different symbols, that however, are always the same.
The other reason was that before the size was estimated using
total_size, which has a well defined meaning for anArraybut in case of aViewits meaning is not fully clear.For these reasons the asserts was removed.