Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dependency on read-writer queue #14

Open
3 tasks
mcopik opened this issue Nov 14, 2021 · 4 comments
Open
3 tasks

Add dependency on read-writer queue #14

mcopik opened this issue Nov 14, 2021 · 4 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mcopik
Copy link
Contributor

mcopik commented Nov 14, 2021

We should add readerwriterqueue as a proper dependency in the CMake build. Furthermore, we want to fetch and build Pistache to avoid the trouble of forcing users to install it manually.

  • Fetch the dependency with CMake.
  • Ensure that include directories are properly configured.
  • Add in the README proper acknowledgment of the other project.
@mcopik mcopik added the enhancement New feature or request label Nov 14, 2021
@mcopik mcopik added the good first issue Good for newcomers label Mar 6, 2023
@Yuanmxc
Copy link
Contributor

Yuanmxc commented Mar 22, 2023

I'll try to file a pr for this, but I'm wondering how to handle versioning of the library

@mcopik
Copy link
Contributor Author

mcopik commented Mar 22, 2023

@Origin-yy I think we can fetch the tag corresponding to the lastest release. You can also compare it against the version we included in our code to check if there are any potential incompatibilities.

@Mac16661
Copy link

I am new to open source development, but I'm eager to learn and contribute to resolving this issue.

@mcopik
Copy link
Contributor Author

mcopik commented Sep 11, 2023

@Mac16661 I recommend starting with looking at CMake FetchModule - we want to use that to add the library as a component :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants