Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in Conformance chapter #1047

Merged
merged 4 commits into from
Aug 11, 2024
Merged

Conversation

zvr
Copy link
Member

@zvr zvr commented Aug 11, 2024

  • adds the section on trademark conformance, from SPDXv2 standard
  • remove the numbering of profiles chapters in second bullet list
  • in the same section, fixes that only Core is mandatory
  • delete the last section, since this is about serializations -- and we definitely do not want to mention Tag-Value or Spreadsheets as "current supported formats"

Fixes #1045

Signed-off-by: Alexios Zavras github@zvr.gr

Signed-off-by: Alexios Zavras <github@zvr.gr>
@zvr
Copy link
Member Author

zvr commented Aug 11, 2024

Depending on the order of merging (the number removal and the link to json), this might have conflicts, but they should be obvious.

@zvr zvr requested review from bact, goneall and kestewart August 11, 2024 17:19
@zvr zvr added this to the 3.0.1 milestone Aug 11, 2024
Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of the additions make sense and am good with, however not sure why Lite & Extension Profile Conformance point information was removed?

docs/conformance.md Outdated Show resolved Hide resolved
docs/conformance.md Outdated Show resolved Hide resolved
Signed-off-by: Alexios Zavras <github@zvr.gr>
@zvr zvr requested a review from kestewart August 11, 2024 19:48
zvr and others added 2 commits August 11, 2024 22:51
Signed-off-by: Alexios Zavras (zvr) <github@zvr.gr>
Signed-off-by: Gary O'Neall <gary@sourceauditor.com>
Copy link
Member

@goneall goneall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kestewart kestewart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussions, Standard Data Format will be added back in future version, after we sort through the serialization chapter.

Copy link

@bobmartin3000 bobmartin3000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@bact bact left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - the information about data format is covered enough for now in Serialization chapter

@goneall goneall merged commit 952a432 into spdx:development/v3.0.1 Aug 11, 2024
2 checks passed
@zvr zvr deleted the fix-conformance branch August 12, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Conformance chapter
5 participants