Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

common/common.views.xml: PHSub Form: Cell is missing proper closing element /> #1223

Open
mcruz-umich opened this issue Oct 17, 2023 · 1 comment
Open

common/common.views.xml: PHSub Form: Cell is missing proper closing element /> #1223

mcruz-umich opened this issue Oct 17, 2023 · 1 comment

Comments

@mcruz-umich
Copy link

https://github.com/specify/specify6/blob/945d28f00288d2d64979848fb2fb63fda34bdd1b/config/common/common.views.xml#L5221C23-L5221C23

Form is missing proper closing element />

Currently does not affect things since it is within a comment but it may cause confusion for editors when they try to activate this field by using the demo text.
@mcruz-umich mcruz-umich changed the title Form is missing proper closing element /> common/common.views.xml: PHSub Form: Cell is missing proper closing element /> Oct 17, 2023
@maxpatiiuk
Copy link
Member

Thanks for catching this!

We are working on a form editing UI that would hopefully remove the possibility of such typos

maxpatiiuk added a commit that referenced this issue Oct 18, 2023
@maxpatiiuk
fix(views): Confusing commented out node syntax
43ea47c 
Fixes #1223

Thanks to @mcruz-umich for reporting this
@maxpatiiuk maxpatiiuk linked a pull request Oct 18, 2023 that will close this issue
Fix mistakes in XML files #1203
Closed
grantfitzsimmons added a commit to specify/specify7 that referenced this issue Nov 7, 2024
@grantfitzsimmons
Fix missing closing elements
1a43e7f 
Fixes specify/specify6#1223
@grantfitzsimmons grantfitzsimmons mentioned this issue Nov 7, 2024
Open
36 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix mistakes in XML files specify/specify6
2 participants
@mcruz-umich @maxpatiiuk