Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When changing a pick list to read only, it requires a size limit of at least two #1515

Closed
tlammer opened this issue May 10, 2022 · 7 comments · Fixed by #5367
Closed

When changing a pick list to read only, it requires a size limit of at least two #1515

tlammer opened this issue May 10, 2022 · 7 comments · Fixed by #5367
Labels
1 - Bug Incorrect behavior of the product 2 - Forms Issues that are related to the form system

Comments

@tlammer
Copy link

tlammer commented May 10, 2022

When checking the box to make a pick list read only, it won't save unless you enter a size limit of at least two. However, that field becomes irrelevant when a pick list is read only so it should be greyed out.

To replicate:
Open an existing pick list that is NOT read only (I used
Check the read only box
Click save
A message saying the count should be at least two appears

image

@tlammer tlammer added 1 - Bug Incorrect behavior of the product pri:unknown labels May 10, 2022
@maxpatiiuk
Copy link
Member

It is set that way in the form definition:

<cell id="sizeLimit" initialize="max=500;min=2" isrequired="true" name="sizeLimit" type="field" uitype="spinner" />

Other than the form definition, there is no reason why it can't be -1. Specify 7 would handle both 0 and -1 as "no limit"

@tlammer
Copy link
Author

tlammer commented May 11, 2022

Which form definition is it reading from? the accession form definition for that field just says make it a pick list, it does not include size or other information.

@maxpatiiuk
Copy link
Member

It looks like the picklist view is part of system views.
It is not editable in the UI, but you can overwrite the default view by adding your own definition.
Here is how a default view looks like:
https://github.com/specify/specify6/blob/24cbca18e126ac0a68d1343eb4ee32326e3b5bf5/config/backstop/system.views.xml#L166

It also means that we can update this view with new specify 6 release

@maxpatiiuk
Copy link
Member

To clarify, Specify 6 disables the "sizeLimit" field if pick list is read only.
It probably makes sense to replicate that behavior in Specify 7

@maxpatiiuk maxpatiiuk removed this from Form Changes Mar 8, 2023
@grantfitzsimmons grantfitzsimmons added 2 - Forms Issues that are related to the form system and removed Unsorted labels Jul 2, 2023
@emenslin
Copy link
Collaborator

Can recreate in edge (7.9.6)

@grantfitzsimmons
Copy link
Member

New

Image

Old

Image

@grantfitzsimmons
Copy link
Member

Fixed in 56c4059

@grantfitzsimmons grantfitzsimmons linked a pull request Nov 6, 2024 that will close this issue
36 tasks
@grantfitzsimmons grantfitzsimmons moved this to In Progress in Form Changes Nov 6, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Form Changes Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 - Bug Incorrect behavior of the product 2 - Forms Issues that are related to the form system
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

4 participants