Table name and field name appearing as invalid

[grantfitzsimmons]

When viewing the RefrenceWorkType pick list, the Table Name and Field Name are displaying as invalid.

db: newmexico_july22
user: spadmin

https://a11y-2-2.test.specifysystems.org/specify/view/picklist/14/

[maxpatiiuk]

They are invalid because pick list type is User Defined Items

Pick lists that contain user defined items are not supposed to have table name or field name

[maxpatiiuk]

Changing the pick list type removes the invalid value labels

[maxpatiiuk]

Those fields should probably be hidden when not applicable.

We have #364 open for that

[grantfitzsimmons]

I had not changed the type. This is a pick list that was assigned to a field by default and has had no modifications

[maxpatiiuk]

Was it there by default after database got created?
If so, our default pick lists are a bit invalid

[grantfitzsimmons]

Yes. I believe it is the default, unmodified ReferenceWorkType pick list assigned to Reference Work -> referenceWorkType

[maxpatiiuk]

Okay. It's not a big issue, because they would just be ignored.

Hiding portions of the form depending on pick list type would hide the fields that don't apply and make this less confusing