Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistencies in rotor direction usage #15

Open
Tuxliri opened this issue Jan 14, 2025 · 0 comments
Open

Inconsistencies in rotor direction usage #15

Tuxliri opened this issue Jan 14, 2025 · 0 comments

Comments

@Tuxliri
Copy link

Tuxliri commented Jan 14, 2025

# with the z axis and that the "sign" of each rotor yaw moment alternates starting with positive for r1. 'TM' = "thrust and moments"
#5 modified the computation of the matrix self.f_to_TM to account for different rotor spin directions, however the comment above still reports the assumption of alternating signs starting with a positive sign, has this been dropped?

In the Multirotor class there is a similar assumption reported in the comment that also seems to have been dropped in the code, is this correct?

# Below is an automated generation of the control allocator matrix. It assumes that all thrust vectors are aligned
# with the z axis and that the "sign" of each rotor yaw moment alternates starting with positive for r1.
self.f_to_TM = np.vstack((np.ones((1,self.num_rotors)),np.hstack([np.cross(self.rotor_pos[key],np.array([0,0,1])).reshape(-1,1)[0:2] for key in self.rotor_pos]), (k * self.rotor_dir).reshape(1,-1)))
self.TM_to_f = np.linalg.inv(self.f_to_TM)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant