-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement]: Newspaper rule. #1038
Comments
yeah, cool idea - wanna take a look at these lists? |
@spencermountain This should avoid dates etc. But we can simply change the rule for numbers / dates etc... But I think it should be added (something like this - regardless if not going to match all patterns but most typical newspapers. Example - The Chicago Times.) |
@spencermountain - thinking we should modify the rules / make some rules for These one's are harder - and probably should just be left out.
|
Was working on this. Don't know where to submit it for PR. Feel free to mention any concerns or add any tweaks / boolean for your test suites etc (if you wanna put this in).
This should help catch a large amount of news papers.
Was thinking maybe some rules for ``Sun, Sun-Times, Star, Free Press, Journal``` could be added - but might be harder.
Tho - we should be allowing years to be passed / and I thought the "date" rule might be necessary but not really sure. We don't express our selves usually like "the Toronto times tomorrow" or "the Toronto times yesterday"
ps; this will tags this like "Canada Post" as newspaper.
The text was updated successfully, but these errors were encountered: