-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Issue]: "My favorite time of the year" in .nouns() response #1096
Comments
@spencermountain maybe split by compound nouns? As they should be grouped together but other nouns not...? Ps; I think I got a list somewhere to of compound nouns to throw at you from awhile back somewhere too! |
@spencermountain - I don't know if best approach to this is writing a rule for this such as is "[#PossessiveNoun] #Adjective" > tag group (0) as possessive determiner. Which this response from GPT might help write this rule: In English grammar, possessive pronouns typically do not directly modify adjectives. Instead, they typically modify nouns. For example:
Possessive pronoun modifying a noun: "That is my favorite book."
Adjective modifying a noun: "That is a beautiful book."
However, there are cases where possessive pronouns can indirectly modify adjectives through the noun they are associated with:
"That is my favorite red book."
Here, "my" is a possessive pronoun modifying the noun "book," and "red" is an adjective modifying "book." So indirectly, "my" can influence the adjective "red" by modifying the noun "book." Then regardless still tokenize all nouns out as single noun or compound nouns. So this doesn't occur just with this phrase, as there were countless phrasing tokenizing as chunks almost.. (Maybe we have to peak into library and see if something is going on...?) As always too, hope you had an awesome weekend. |
Just doing some playing again and seen this gets tagged as all nouns.
I am sure there are various other sentences that some more rules need to be added for. If you have any ideas for DBs with POS tagged we could throw at this to identify some other patterns etc.
As I am sure we could open issues like this one all day long etc..
The text was updated successfully, but these errors were encountered: