-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compromise-dates plugin mutates context param obj on function calls #1109
Comments
Hey! Good catch - .json should definitely never mutate the object - getting swamped at work, will look at a fix hopefully this weekend |
Thanks @spencermountain, no worries! Just to reiterate, it seems to be all/most of the |
hey Frazer, think this is fixed in the 3.6.0 release of compromise-dates. Please let me know if you see any other funny-biz |
Great, thanks Spencer! |
Node version: 20.13.1
Compromise version: 14.13.0
Compromise-dates version: 3.5.0
Using the compromise-dates plugin, any call to the
.dates()
functions (.json()
,.get()
,.format()
etc.) mutates thetoday
value in the context param obj to a SpaceTime object, which is an unexpected side-effect:The text was updated successfully, but these errors were encountered: