-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
people() seems to get confused by commas #1111
Comments
hey Sandro - good catch! |
got it fixed in 14.14.0! |
I'd like to tell and celebrate the value of the work you do to build and maintain this excellent library. So I'll share a concrete example of the positive impact your diligence makes. This is the test output I was seeing which prompted my original question:
Then you released 14.14.0, and I updated to that version. I did nothing else. This is now the test output:
Happy start to the day. Thank you. |
Great library!
Loving the various entity extraction utilities. They work great. One I use is
people()
. However, it seems to be unable to separate a list of comma-separated names into individual names, at least in this case.This is what I'm seeing [ NodeJs 22, OSX, "compromise": "^14.13.0" ]:
As a side note, you can also see it isn't catching
W.E.B Du Bois
but that seems a complex pattern, and prob best here would be to add to the custom lexicon I'm guessing.Thanks again for
compromise
!The text was updated successfully, but these errors were encountered: