From 6bacfbfd122bcdefc646111bde7c98cc9d32d6ad Mon Sep 17 00:00:00 2001 From: jooho lee Date: Thu, 18 Jul 2024 05:53:59 -0400 Subject: [PATCH] set protocol https for .Status.Address.URL Signed-off-by: jooho lee --- pkg/controller/v1beta1/inferenceservice/controller_test.go | 2 +- .../inferenceservice/reconcilers/ingress/ingress_reconciler.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/controller/v1beta1/inferenceservice/controller_test.go b/pkg/controller/v1beta1/inferenceservice/controller_test.go index b9aa13ada41..e493bc92c1f 100644 --- a/pkg/controller/v1beta1/inferenceservice/controller_test.go +++ b/pkg/controller/v1beta1/inferenceservice/controller_test.go @@ -1871,7 +1871,7 @@ var _ = Describe("v1beta1 inference service controller", func() { Host: constants.InferenceServiceHostName(constants.PredictorServiceName(serviceKey.Name), serviceKey.Namespace, domain), })) Expect(actualIsvc.Status.Address.URL).To(gomega.Equal(&apis.URL{ - Scheme: "http", + Scheme: "https", Host: network.GetServiceHostname(fmt.Sprintf("%s-%s", serviceKey.Name, string(constants.Predictor)), serviceKey.Namespace), })) }) diff --git a/pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go b/pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go index ae1a9aa3ce4..4f00c9204da 100644 --- a/pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go +++ b/pkg/controller/v1beta1/inferenceservice/reconcilers/ingress/ingress_reconciler.go @@ -611,7 +611,7 @@ func (ir *IngressReconciler) Reconcile(isvc *v1beta1.InferenceService) error { isvc.Status.Address = &duckv1.Addressable{ URL: &apis.URL{ Host: network.GetServiceHostname(hostPrefix, isvc.Namespace), - Scheme: "http", + Scheme: "https", }, } isvc.Status.SetCondition(v1beta1.IngressReady, &apis.Condition{