From 94c886a907ec01fce0be604641870ce265f89b3a Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Tue, 24 Oct 2023 11:02:04 +0300 Subject: [PATCH 1/8] add update strategy --- charts/ocean-network-client/templates/daemon_set.yaml | 4 ++++ charts/ocean-network-client/values.yaml | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/charts/ocean-network-client/templates/daemon_set.yaml b/charts/ocean-network-client/templates/daemon_set.yaml index fa73dd8..9df3001 100644 --- a/charts/ocean-network-client/templates/daemon_set.yaml +++ b/charts/ocean-network-client/templates/daemon_set.yaml @@ -7,6 +7,10 @@ spec: selector: matchLabels: {{- include "ocean-network-client.daemon-set.labels" . | nindent 6 }} + {{- with .Values.updateStrategy }} + updateStrategy: + {{- toYaml . | nindent 4 }} + {{- end }} template: metadata: labels: diff --git a/charts/ocean-network-client/values.yaml b/charts/ocean-network-client/values.yaml index 177637b..da26c58 100644 --- a/charts/ocean-network-client/values.yaml +++ b/charts/ocean-network-client/values.yaml @@ -30,3 +30,9 @@ resources: # Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ tolerations: - operator: "Exists" + +updateStrategy: + type: RollingUpdate + rollingUpdate: + maxSurge: 0 + maxUnavailable: 10% \ No newline at end of file From 322bccbc4701a811e09bccdb1aca5ffa255b10d9 Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Tue, 24 Oct 2023 13:39:14 +0300 Subject: [PATCH 2/8] bump version --- charts/ocean-network-client/Chart.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/ocean-network-client/Chart.yaml b/charts/ocean-network-client/Chart.yaml index cdcdf18..e1bf3cc 100644 --- a/charts/ocean-network-client/Chart.yaml +++ b/charts/ocean-network-client/Chart.yaml @@ -17,7 +17,7 @@ maintainers: # This is the chart version. This version number should be incremented each time you make changes # to the chart and its templates, including the app version. # Versions are expected to follow Semantic Versioning (https://semver.org/) -version: 1.0.12 +version: 1.0.13 # This is the version number of the application being deployed. This version number should be # incremented each time you make changes to the application. Versions are not expected to From a66528633fc3bfe1a22830a61a16a24af8be4660 Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Tue, 24 Oct 2023 13:47:26 +0300 Subject: [PATCH 3/8] bump version try 2 --- charts/ocean-network-client/values.yaml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/ocean-network-client/values.yaml b/charts/ocean-network-client/values.yaml index da26c58..db09386 100644 --- a/charts/ocean-network-client/values.yaml +++ b/charts/ocean-network-client/values.yaml @@ -35,4 +35,4 @@ updateStrategy: type: RollingUpdate rollingUpdate: maxSurge: 0 - maxUnavailable: 10% \ No newline at end of file + maxUnavailable: 10% From a6501ea83b8a717848c4f623d448b49474d2654f Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Wed, 25 Oct 2023 09:07:37 +0300 Subject: [PATCH 4/8] fix readme --- charts/ocean-network-client/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/charts/ocean-network-client/README.md b/charts/ocean-network-client/README.md index c7a0e93..78c9955 100644 --- a/charts/ocean-network-client/README.md +++ b/charts/ocean-network-client/README.md @@ -1,6 +1,6 @@ # ocean-network-client -![Version: 1.0.12](https://img.shields.io/badge/Version-1.0.12-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.4](https://img.shields.io/badge/AppVersion-1.0.4-informational?style=flat-square) +![Version: 1.0.13](https://img.shields.io/badge/Version-1.0.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.4](https://img.shields.io/badge/AppVersion-1.0.4-informational?style=flat-square) A Helm chart for Ocean Network Client From 2d0a964a92171558d94932377a449532e08e3f27 Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Wed, 25 Oct 2023 10:45:30 +0300 Subject: [PATCH 5/8] PR fix, bump Appversion --- charts/ocean-network-client/Chart.yaml | 2 +- charts/ocean-network-client/README.md | 26 +++++++++++++------------- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/charts/ocean-network-client/Chart.yaml b/charts/ocean-network-client/Chart.yaml index e1bf3cc..9f8abbf 100644 --- a/charts/ocean-network-client/Chart.yaml +++ b/charts/ocean-network-client/Chart.yaml @@ -23,4 +23,4 @@ version: 1.0.13 # incremented each time you make changes to the application. Versions are not expected to # follow Semantic Versioning. They should reflect the version the application is using. # It is recommended to use it with quotes. -appVersion: "1.0.4" +appVersion: "1.0.5" diff --git a/charts/ocean-network-client/README.md b/charts/ocean-network-client/README.md index 78c9955..f89a211 100644 --- a/charts/ocean-network-client/README.md +++ b/charts/ocean-network-client/README.md @@ -1,6 +1,6 @@ # ocean-network-client -![Version: 1.0.13](https://img.shields.io/badge/Version-1.0.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.4](https://img.shields.io/badge/AppVersion-1.0.4-informational?style=flat-square) +![Version: 1.0.13](https://img.shields.io/badge/Version-1.0.13-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.0.5](https://img.shields.io/badge/AppVersion-1.0.5-informational?style=flat-square) A Helm chart for Ocean Network Client @@ -42,17 +42,17 @@ helm install my-release spot/ocean-network-client ## Values -| Key | Type | Default | Description | -|-----|------|---------|-------------| -| image.pullPolicy | Optional | `"Always"` | Image pull policy. | -| image.pullSecrets | Optional | `[]` | Image pull secrets. | -| image.repository | Optional | `"public.ecr.aws/spotinst/spot-network-client"` | Image repository. | -| image.tag | Optional | `""` | Image tag. Defaults to `.Chart.AppVersion`. | -| namespace | Optional | `"kube-system"` | Namespace where components should be installed. | -| oceanController.configMapName | Optional | `"spotinst-kubernetes-cluster-controller-config"` | ConfigMap name. | -| oceanController.secretName | Optional | `"spotinst-kubernetes-cluster-controller"` | Secret name. | -| resources | Optional | `{"limits":{"cpu":"300m","memory":"500Mi"},"requests":{"cpu":"10m","memory":"100Mi"}}` | Resource requests and limits. Ref: http://kubernetes.io/docs/user-guide/compute-resources/ | -| tolerations | Optional | `[{"operator":"Exists"}]` | Tolerations - Enable pods to run an all nodes in cluster Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | - +| Key | Type | Default | Description | +|-----|------|----------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------| +| image.pullPolicy | Optional | `"Always"` | Image pull policy. | +| image.pullSecrets | Optional | `[]` | Image pull secrets. | +| image.repository | Optional | `"public.ecr.aws/spotinst/spot-network-client"` | Image repository. | +| image.tag | Optional | `""` | Image tag. Defaults to `.Chart.AppVersion`. | +| namespace | Optional | `"kube-system"` | Namespace where components should be installed. | +| oceanController.configMapName | Optional | `"spotinst-kubernetes-cluster-controller-config"` | ConfigMap name. | +| oceanController.secretName | Optional | `"spotinst-kubernetes-cluster-controller"` | Secret name. | +| resources | Optional | `{"limits":{"cpu":"300m","memory":"500Mi"},"requests":{"cpu":"10m","memory":"100Mi"}}` | Resource requests and limits. Ref: http://kubernetes.io/docs/user-guide/compute-resources/ | +| tolerations | Optional | `[{"operator":"Exists"}]` | Tolerations - Enable pods to run an all nodes in cluster Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | +| updateStrategy | Optional | `{"type":"RollingUpdate"},"rollingUpdate":{"maxSurge":"0","maxUnavailable":"10%"}}` | updateStrategy. Ref: https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/ | ---------------------------------------------- Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0) From 96b5b67706f72f3036ad94ad9a5987585ac4b25b Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Wed, 25 Oct 2023 10:55:55 +0300 Subject: [PATCH 6/8] clean --- charts/ocean-network-client/README.md | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/charts/ocean-network-client/README.md b/charts/ocean-network-client/README.md index f89a211..36b426b 100644 --- a/charts/ocean-network-client/README.md +++ b/charts/ocean-network-client/README.md @@ -42,17 +42,17 @@ helm install my-release spot/ocean-network-client ## Values -| Key | Type | Default | Description | -|-----|------|----------------------------------------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------| -| image.pullPolicy | Optional | `"Always"` | Image pull policy. | -| image.pullSecrets | Optional | `[]` | Image pull secrets. | -| image.repository | Optional | `"public.ecr.aws/spotinst/spot-network-client"` | Image repository. | -| image.tag | Optional | `""` | Image tag. Defaults to `.Chart.AppVersion`. | -| namespace | Optional | `"kube-system"` | Namespace where components should be installed. | -| oceanController.configMapName | Optional | `"spotinst-kubernetes-cluster-controller-config"` | ConfigMap name. | -| oceanController.secretName | Optional | `"spotinst-kubernetes-cluster-controller"` | Secret name. | -| resources | Optional | `{"limits":{"cpu":"300m","memory":"500Mi"},"requests":{"cpu":"10m","memory":"100Mi"}}` | Resource requests and limits. Ref: http://kubernetes.io/docs/user-guide/compute-resources/ | -| tolerations | Optional | `[{"operator":"Exists"}]` | Tolerations - Enable pods to run an all nodes in cluster Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | -| updateStrategy | Optional | `{"type":"RollingUpdate"},"rollingUpdate":{"maxSurge":"0","maxUnavailable":"10%"}}` | updateStrategy. Ref: https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/ | +| Key | Type | Default | Description | +|-----|------|---------|-------------| +| image.pullPolicy | Optional | `"Always"` | Image pull policy. | +| image.pullSecrets | Optional | `[]` | Image pull secrets. | +| image.repository | Optional | `"public.ecr.aws/spotinst/spot-network-client"` | Image repository. | +| image.tag | Optional | `""` | Image tag. Defaults to `.Chart.AppVersion`. | +| namespace | Optional | `"kube-system"` | Namespace where components should be installed. | +| oceanController.configMapName | Optional | `"spotinst-kubernetes-cluster-controller-config"` | ConfigMap name. | +| oceanController.secretName | Optional | `"spotinst-kubernetes-cluster-controller"` | Secret name. | +| resources | Optional | `{"limits":{"cpu":"300m","memory":"500Mi"},"requests":{"cpu":"10m","memory":"100Mi"}}` | Resource requests and limits. Ref: http://kubernetes.io/docs/user-guide/compute-resources/ | +| tolerations | Optional | `[{"operator":"Exists"}]` | Tolerations - Enable pods to run an all nodes in cluster Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | +| updateStrategy | Optional | `{"type":"RollingUpdate"},"rollingUpdate":{"maxSurge":"0","maxUnavailable":"10%"}}` | updateStrategy. Ref: https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/ | ---------------------------------------------- Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0) From a4887c733e31e44c7d03223f2af1918e733d2e37 Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Thu, 26 Oct 2023 10:45:34 +0300 Subject: [PATCH 7/8] hardcoded updateStrategy --- charts/ocean-network-client/README.md | 6 +++--- charts/ocean-network-client/templates/daemon_set.yaml | 6 +++--- charts/ocean-network-client/values.yaml | 5 ----- 3 files changed, 6 insertions(+), 11 deletions(-) diff --git a/charts/ocean-network-client/README.md b/charts/ocean-network-client/README.md index 36b426b..b8bd0ba 100644 --- a/charts/ocean-network-client/README.md +++ b/charts/ocean-network-client/README.md @@ -47,12 +47,12 @@ helm install my-release spot/ocean-network-client | image.pullPolicy | Optional | `"Always"` | Image pull policy. | | image.pullSecrets | Optional | `[]` | Image pull secrets. | | image.repository | Optional | `"public.ecr.aws/spotinst/spot-network-client"` | Image repository. | -| image.tag | Optional | `""` | Image tag. Defaults to `.Chart.AppVersion`. | +| image.tag | Optional | `""` | Image tag. Defaults to `.Chart.AppVersion`. | | namespace | Optional | `"kube-system"` | Namespace where components should be installed. | | oceanController.configMapName | Optional | `"spotinst-kubernetes-cluster-controller-config"` | ConfigMap name. | | oceanController.secretName | Optional | `"spotinst-kubernetes-cluster-controller"` | Secret name. | -| resources | Optional | `{"limits":{"cpu":"300m","memory":"500Mi"},"requests":{"cpu":"10m","memory":"100Mi"}}` | Resource requests and limits. Ref: http://kubernetes.io/docs/user-guide/compute-resources/ | +| resources | Optional | `{"limits":{"cpu":"300m","memory":"500Mi"},"requests":{"cpu":"10m","memory":"100Mi"}}` | Resource requests and limits. Ref: http://kubernetes.io/docs/user-guide/compute-resources/ | | tolerations | Optional | `[{"operator":"Exists"}]` | Tolerations - Enable pods to run an all nodes in cluster Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ | -| updateStrategy | Optional | `{"type":"RollingUpdate"},"rollingUpdate":{"maxSurge":"0","maxUnavailable":"10%"}}` | updateStrategy. Ref: https://kubernetes.io/docs/tasks/manage-daemon/update-daemon-set/ | + ---------------------------------------------- Autogenerated from chart metadata using [helm-docs v1.11.0](https://github.com/norwoodj/helm-docs/releases/v1.11.0) diff --git a/charts/ocean-network-client/templates/daemon_set.yaml b/charts/ocean-network-client/templates/daemon_set.yaml index 9df3001..8d97f17 100644 --- a/charts/ocean-network-client/templates/daemon_set.yaml +++ b/charts/ocean-network-client/templates/daemon_set.yaml @@ -7,10 +7,10 @@ spec: selector: matchLabels: {{- include "ocean-network-client.daemon-set.labels" . | nindent 6 }} - {{- with .Values.updateStrategy }} updateStrategy: - {{- toYaml . | nindent 4 }} - {{- end }} + rollingUpdate: + maxSurge: 0 + maxUnavailable: 10% template: metadata: labels: diff --git a/charts/ocean-network-client/values.yaml b/charts/ocean-network-client/values.yaml index db09386..869286c 100644 --- a/charts/ocean-network-client/values.yaml +++ b/charts/ocean-network-client/values.yaml @@ -31,8 +31,3 @@ resources: tolerations: - operator: "Exists" -updateStrategy: - type: RollingUpdate - rollingUpdate: - maxSurge: 0 - maxUnavailable: 10% From f1edb0eb06bac5e338be20292fe8246ae470dbc3 Mon Sep 17 00:00:00 2001 From: yehielnetapp Date: Thu, 26 Oct 2023 10:48:38 +0300 Subject: [PATCH 8/8] hardcoded updateStrategy 2 --- charts/ocean-network-client/values.yaml | 1 - 1 file changed, 1 deletion(-) diff --git a/charts/ocean-network-client/values.yaml b/charts/ocean-network-client/values.yaml index 869286c..177637b 100644 --- a/charts/ocean-network-client/values.yaml +++ b/charts/ocean-network-client/values.yaml @@ -30,4 +30,3 @@ resources: # Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/taint-and-toleration/ tolerations: - operator: "Exists" -