From 1b33fbf4230bca22afb1e1c044d89548f9d218e6 Mon Sep 17 00:00:00 2001 From: Z4ck404 Date: Wed, 15 Nov 2023 16:47:51 +0100 Subject: [PATCH] [.github] clean + add codeowners --- .github/CODEOWNERS | 2 + .github/pull_request_template.md | 37 +++++++----- .github/workflows/answered.yml | 26 --------- .github/workflows/auto_author_assign.yml | 15 ----- .github/workflows/check-i18n.yml | 48 --------------- .github/workflows/check-release.yml | 33 ----------- .github/workflows/enforce-label.yml | 13 ----- .github/workflows/galata.yml | 74 ------------------------ .github/workflows/labeler.yml | 16 ----- .github/workflows/lock.yml | 23 -------- 10 files changed, 23 insertions(+), 264 deletions(-) create mode 100644 .github/CODEOWNERS delete mode 100644 .github/workflows/answered.yml delete mode 100644 .github/workflows/auto_author_assign.yml delete mode 100644 .github/workflows/check-i18n.yml delete mode 100644 .github/workflows/check-release.yml delete mode 100644 .github/workflows/enforce-label.yml delete mode 100644 .github/workflows/galata.yml delete mode 100644 .github/workflows/labeler.yml delete mode 100644 .github/workflows/lock.yml diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000000..cf004b55697c --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,2 @@ +* @Spotinst/team-bigdata +/.github/ @Spotinst/team-bigdata-devops \ No newline at end of file diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 13420d59f51b..23de33d09d39 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,26 +1,31 @@ - +## Jira ticket -## References +https://spotinst.atlassian.net/browse/BGD-XXXX - +## Checklist +- [ ] I added a Jira ticket link +- [ ] I added a changeset with the `simple-changeset add` command +- [ ] I filled in the test plan +- [ ] I executed the tests and filled in the test results - +## Why -## Code changes +_A short description of why this change is necessary. If this is a bug fix, include steps to reproduce the issue_ - +## What -## User-facing changes +_What has been modified. Expose the key decisions you have made during this PR to facilitate the discussion with your reviewer_ - +## How to test - +_Step by step instructions to test your feature/fix_ -## Backwards-incompatible changes +## Test plan and results - +_Feel free to add screenshots showing test results_ + +| Test | Description | Result | Notes | +|------|-------------------|--------|----------------------------| +| 1 | Test with input A | Pass | Some notes about the test | +| 2 | Test with input B | Pass | Some notes about the test | +| 3 | Test with input C | Pass | Some notes about the test | diff --git a/.github/workflows/answered.yml b/.github/workflows/answered.yml deleted file mode 100644 index 0d358f52be37..000000000000 --- a/.github/workflows/answered.yml +++ /dev/null @@ -1,26 +0,0 @@ -# This action automatically schedules issues to be closed that have been -# labeled as answered if there is no activity on them for 30 days. This takes -# care of the common usecase of an issue being answered to the best of our -# ability and no other follow-up from the submitter. -name: 'Close answered issues' -on: - schedule: - - cron: '30 1 * * *' - -permissions: - issues: write - -jobs: - stale: - runs-on: ubuntu-latest - steps: - - uses: actions/stale@v3 - with: - days-before-pr-stale: -1 - days-before-pr-close: -1 - skip-stale-issue-message: true - days-before-issue-stale: 30 - days-before-issue-close: 7 - stale-issue-label: 'status:Closing as Answered' - stale-issue-message: '.' - only-issue-labels: 'status:Answered' diff --git a/.github/workflows/auto_author_assign.yml b/.github/workflows/auto_author_assign.yml deleted file mode 100644 index c7a7902f4b24..000000000000 --- a/.github/workflows/auto_author_assign.yml +++ /dev/null @@ -1,15 +0,0 @@ -# https://github.com/marketplace/actions/auto-author-assign -name: 'Auto Author Assign' - -on: - pull_request_target: - types: [opened, reopened] - -permissions: - pull-requests: write - -jobs: - assign-author: - runs-on: ubuntu-latest - steps: - - uses: toshimaru/auto-author-assign@v1.3.4 diff --git a/.github/workflows/check-i18n.yml b/.github/workflows/check-i18n.yml deleted file mode 100644 index 52f34c8d918d..000000000000 --- a/.github/workflows/check-i18n.yml +++ /dev/null @@ -1,48 +0,0 @@ -name: Check internationalization changes - -on: - pull_request: - -jobs: - check_i18n: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2 - - - name: Base Setup - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - - - name: Install dependencies - run: | - python -m pip install -U pip jupyterlab-translate~=1.0 - - - name: Compute hash - id: currentHash - run: | - set -eux - HASH=$(python scripts/i18n_check.py | tail -n1) - echo "::set-output name=i18n::${HASH}" - - - name: Checkout target - run: | - echo Checking ${GITHUB_BASE_REF}... - # Ref https://github.com/actions/checkout/issues/93 - git fetch --depth=1 origin +refs/heads/${GITHUB_BASE_REF}:refs/remotes/origin/${GITHUB_BASE_REF} - git checkout ${GITHUB_BASE_REF} - - - name: Check hash - env: - CURRENT: ${{ steps.currentHash.outputs.i18n }} - run: | - set -eux - EXPECTED=$(python scripts/i18n_check.py | tail -n1) - if [[ "${CURRENT}" != "${EXPECTED}" ]]; then - echo "Translatable strings have changed, this is only allowed on major or minor version bumps." - # Set job status as failed if - # - branch is not "master" - # - and current version is not a pre release of a zeroed patch version - if [[ "${GITHUB_BASE_REF}" != "master" && ! ( $(python setup.py --version) =~ ^[0-9]+\.[0-9]+\.0(\.dev|a|b|rc)[0-9]+$ ) ]]; then - exit 1 - fi - fi diff --git a/.github/workflows/check-release.yml b/.github/workflows/check-release.yml deleted file mode 100644 index 3a683fade0f9..000000000000 --- a/.github/workflows/check-release.yml +++ /dev/null @@ -1,33 +0,0 @@ -name: Check Release - -on: - push: - branches: [3.6.x] - pull_request: - branches: [3.6.x] - release: - types: [published] - -jobs: - - check_release: - runs-on: ubuntu-latest - steps: - - name: Checkout - uses: actions/checkout@v2 - - - name: Base Setup - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - - - name: Check Release - uses: jupyter-server/jupyter_releaser/.github/actions/check-release@v2 - with: - token: ${{ secrets.GITHUB_TOKEN }} - version_spec: next - - - name: Upload Assets - uses: actions/upload-artifact@v3 - with: - name: dist-files - path: | - .jupyter_releaser_checkout/dist/*.* diff --git a/.github/workflows/enforce-label.yml b/.github/workflows/enforce-label.yml deleted file mode 100644 index 725feab5ce65..000000000000 --- a/.github/workflows/enforce-label.yml +++ /dev/null @@ -1,13 +0,0 @@ -name: Enforce PR label - -on: - pull_request: - types: [labeled, unlabeled, opened, edited, synchronize] -jobs: - enforce-label: - runs-on: ubuntu-latest - permissions: - pull-requests: write - steps: - - name: enforce-triage-label - uses: jupyterlab/maintainer-tools/.github/actions/enforce-label@v1 diff --git a/.github/workflows/galata.yml b/.github/workflows/galata.yml deleted file mode 100644 index eb9a5c294d6e..000000000000 --- a/.github/workflows/galata.yml +++ /dev/null @@ -1,74 +0,0 @@ -name: UI Tests - -on: - push: - branches: - - '3.6.x' - pull_request: - branches: - - '*' - -jobs: - build: - name: Visual Regression Tests - timeout-minutes: 80 - runs-on: ubuntu-20.04 - steps: - - name: Checkout - uses: actions/checkout@v2 - - - name: Base Setup - uses: jupyterlab/maintainer-tools/.github/actions/base-setup@v1 - - - name: Install dependencies - run: | - bash ./scripts/ci_install.sh - # Build dev-mode - jlpm run build - - - name: Launch JupyterLab - run: | - cd galata - # Mount a volume to overwrite the server configuration - jlpm start 2>&1 > /tmp/jupyterlab_server.log & - - - name: Install browser - run: | - cd galata - # Install only Chromium browser - jlpm playwright install chromium - jlpm run build - - - name: Wait for JupyterLab - uses: ifaxity/wait-on-action@v1 - with: - resource: http-get://localhost:8888/lab - timeout: 360000 - - - name: Test - run: | - cd galata - jlpm run test - # Run once benchmark tests to ensure they have no regression - BENCHMARK_NUMBER_SAMPLES=1 jlpm run test:benchmark - - - name: Upload Galata Test assets - if: always() - uses: actions/upload-artifact@v2 - with: - name: galata-test-assets - path: | - galata/test-results - - - name: Upload Galata Test report - if: always() - uses: actions/upload-artifact@v2 - with: - name: galata-report - path: | - galata/playwright-report - - - name: Print JupyterLab logs - if: always() - run: | - cat /tmp/jupyterlab_server.log diff --git a/.github/workflows/labeler.yml b/.github/workflows/labeler.yml deleted file mode 100644 index 0e28ad5c6e1b..000000000000 --- a/.github/workflows/labeler.yml +++ /dev/null @@ -1,16 +0,0 @@ -# https://github.com/marketplace/actions/labeler -name: "Pull Request Labeler" -on: -- pull_request_target - -permissions: - pull-requests: write - -jobs: - triage: - name: Update PR Labels - runs-on: ubuntu-latest - steps: - - uses: actions/labeler@main - with: - repo-token: "${{ secrets.GITHUB_TOKEN }}" diff --git a/.github/workflows/lock.yml b/.github/workflows/lock.yml deleted file mode 100644 index 478e9292e658..000000000000 --- a/.github/workflows/lock.yml +++ /dev/null @@ -1,23 +0,0 @@ -name: 'Lock Closed Threads' - -on: - schedule: - - cron: '0 0 * * *' - -permissions: - issues: - write - pull-requests: - write - -jobs: - lock: - runs-on: ubuntu-20.04 - steps: - - uses: dessant/lock-threads@v2 - with: - github-token: ${{ github.token }} - issue-lock-inactive-days: '180' - issue-lock-labels: 'status:resolved-locked' - pr-lock-inactive-days: '180' - pr-lock-labels: 'status:resolved-locked'