diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 000000000000..cf004b55697c --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,2 @@ +* @Spotinst/team-bigdata +/.github/ @Spotinst/team-bigdata-devops \ No newline at end of file diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 9f3671a8ce8d..23de33d09d39 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,26 +1,31 @@ - +## Jira ticket -## References +https://spotinst.atlassian.net/browse/BGD-XXXX - +## Checklist +- [ ] I added a Jira ticket link +- [ ] I added a changeset with the `simple-changeset add` command +- [ ] I filled in the test plan +- [ ] I executed the tests and filled in the test results - +## Why -## Code changes +_A short description of why this change is necessary. If this is a bug fix, include steps to reproduce the issue_ - +## What -## User-facing changes +_What has been modified. Expose the key decisions you have made during this PR to facilitate the discussion with your reviewer_ - +## How to test - +_Step by step instructions to test your feature/fix_ -## Backwards-incompatible changes +## Test plan and results - +_Feel free to add screenshots showing test results_ + +| Test | Description | Result | Notes | +|------|-------------------|--------|----------------------------| +| 1 | Test with input A | Pass | Some notes about the test | +| 2 | Test with input B | Pass | Some notes about the test | +| 3 | Test with input C | Pass | Some notes about the test | diff --git a/.github/workflows/common.yaml b/.github/workflows/common.yaml new file mode 100644 index 000000000000..ec7274a87110 --- /dev/null +++ b/.github/workflows/common.yaml @@ -0,0 +1,27 @@ +name: Bigdata Commit Checks + +on: [pull_request] + +jobs: + ci: + runs-on: ubuntu-latest + steps: + - uses: actions/checkout@v3 + + # - name: Install devctl + # run: | + # mkdir -p ${{ env.DEVCTL_INSTALL_DIR }} + # curl -H "Authorization: token ${{ env.GITHUB_TOKEN }}" -o- ${{ env.DEVCTL_INSTALL_URL }} | INSTALL_DIR=${{ env.DEVCTL_INSTALL_DIR }} bash + # echo ${{ env.DEVCTL_INSTALL_DIR }} >> $GITHUB_PATH + # shell: bash + # env: + # DEVCTL_INSTALL_DIR: ${{runner.tool_cache}}/devctl + # DEVCTL_INSTALL_URL: https://raw.githubusercontent.com/spotinst/bigdata-devctl/main/install.sh + # GITHUB_TOKEN: ${{secrets.CI_PAT}} + + # - name: run validation checks + # run: devctl ci + # env: + # GITHUB_TOKEN: ${{secrets.GITHUB_TOKEN}} + # JIRA_TOKEN: ${{ secrets.JIRA_TOKEN }} + # PR_ID: ${{ github.event.pull_request.number }} \ No newline at end of file diff --git a/.github/workflows/enforce-label.yml b/.github/workflows/enforce-label.yml deleted file mode 100644 index 79b6f0eab6c4..000000000000 --- a/.github/workflows/enforce-label.yml +++ /dev/null @@ -1,13 +0,0 @@ -name: Enforce PR label - -on: - pull_request_target: - types: [labeled, unlabeled, opened, edited, synchronize] -jobs: - enforce-label: - runs-on: ubuntu-latest - permissions: - pull-requests: write - steps: - - name: enforce-triage-label - uses: jupyterlab/maintainer-tools/.github/actions/enforce-label@v1