Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_payment.rb, onclick event integration issue #166

Open
YanisThePie opened this issue Aug 18, 2017 · 1 comment
Open

_payment.rb, onclick event integration issue #166

YanisThePie opened this issue Aug 18, 2017 · 1 comment

Comments

@YanisThePie
Copy link

capture d ecran 2017-08-18 a 16 52 54

As you can see, the code about the popup "how Paypal Works" is bad implemented, I found that the issue is here

<% if method.is_a?(Spree::Gateway::BraintreeVzeroPaypalExpress) %> <img src="https://www.paypalobjects.com/webstatic/mktg/logo/pp_cc_mark_37x23.jpg" border="0" alt="PayPal Logo"> <a href="https://www.paypal.com/webapps/mpp/paypal-popup" title="<%= Spree.t(:how_paypal_works) %>" onclick="javascript:window.open('https://www.paypal.com/webapps/mpp/paypal-popup', 'WIPaypal','toolbar=no, location=no, directories=no, status=no, menubar=no, scrollbars=yes, resizable=yes, width=1060, height=700'); return false;"> <%= Spree.t(:what_is_paypal) %></a> <% else %> <%= render_original %> <% end %>
But i don't know if it is a tag issue or something else, if someone know how to solve it?

Thanks

@mdavo6
Copy link
Contributor

mdavo6 commented Nov 1, 2017

@lennonmarley Have you customised the 'spree/checkout/_payment' partial or the localisation files? You could have a stray quotation mark (")?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants