Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

State name conflict #11

Open
OpticNectar opened this issue May 10, 2017 · 1 comment
Open

State name conflict #11

OpticNectar opened this issue May 10, 2017 · 1 comment

Comments

@OpticNectar
Copy link

Can we change the name of the vendor "state" to "status"? State is a bit confusing for us since are adding address, city, state, zipcode, etc as some extra fields to the vendor. Status seems like a more descriptive word and less likely to conflict with anyone's additional fields.

@symarys
Copy link

symarys commented May 11, 2017

'State' made sense to me because it was in line with other fields from Spree (e.g. order or shipment have a state for a similar purpose). I think Vendor can be associated with Address model, so there would be no need to add another 'state' field directly to the Vendor model. Anyway, it may be confusing, so I'll keep your remark in mind when adding extra fields.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants