Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Unnecessary spree_frontend gem #198

Open
edmondchui opened this issue Aug 23, 2023 · 2 comments · May be fixed by #199
Open

Remove Unnecessary spree_frontend gem #198

edmondchui opened this issue Aug 23, 2023 · 2 comments · May be fixed by #199

Comments

@edmondchui
Copy link
Contributor

edmondchui commented Aug 23, 2023

In the pull request for Spree 4.5 update, spree_frontend gem was introduced as a gem dependency. Since I don't use spree_frontend, I got following error when starting my Spree server:

~/.rbenv/versions/3.2.2/lib/ruby/gems/3.2.0/gems/spree_auth_devise-4.5.0/lib/controllers/frontend/spree/auth/checkout_controller_decorator.rb:45:in `<top (required)>': uninitialized constant Spree::CheckoutController (NameError)

Spree::CheckoutController.prepend(Spree::Auth::CheckoutControllerDecorator)
     ^^^^^^^^^^^^^^^^^^^^
	from <internal:/Users/echui/.rbenv/versions/3.2.2/lib/ruby/site_ruby/3.2.0/rubygems/core_ext/kernel_require.rb>:38:in `require'

Also spree_frontend is mentioned in the Update Gemfile section in Spree 4.5 tp 4.6 migration guide, it should not be added for those not using spree_frontend.

I'm requesting to remove spree_frontend from the gemspec.

@edmondchui edmondchui linked a pull request Aug 23, 2023 that will close this issue
@iaderblocklack
Copy link

iaderblocklack commented Jan 18, 2024

@edmondchui do you found how to solve this issue? I have the same error

@edmondchui
Copy link
Contributor Author

@iaderblocklack I've already created this pull request #198 (reference) a while back.
Just need someone to merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants