Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not fail the workflow if binding credential permissions not found #367

Open
LittleBaiBai opened this issue May 8, 2020 · 0 comments
Open

Do not fail the workflow if binding credential permissions not found #367

LittleBaiBai opened this issue May 8, 2020 · 0 comments

Comments

@LittleBaiBai
Copy link
Contributor

LittleBaiBai commented May 8, 2020 •
edited
Loading

When permissions don't exist in credhub, getPermissionsByPathAndActor() and/or getPermissions() would throw CredHubException with status code of 404, resulting CredHubPersistingDeleteServiceInstanceBindingWorkflow to fail. Since the purpose of the workflow is only to make sure environment is cleaned up, I suggest we ignore the 404 CredHubException when permissions are missing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@spikymonkey @LittleBaiBai