Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppDeploymentUpdateServiceInstanceWorkflow is trying to update a service-instances without backing application or backing service. #561

Open
kvmw opened this issue Feb 21, 2022 · 0 comments

Comments

@kvmw
Copy link

kvmw commented Feb 21, 2022

Consider a service definition foo with backing app foo-backing-app and a backing service foo-backing-service.

When a service-instance creation fails for any reason, there might be situations which we have the service-instance (in failed state) but the backing-app and/or backing-service has not been created. So even though service-definition says that every service-instance has a backing-app and a backing-service, there are service-instances without one or both of them. In this case any attempt to update/upgrade above service-instance will fail because AppDeploymentUpdateServiceInstanceWorkflow is not able to find the backing app or service.

This is especially troublesome when upgrade all services operations (batch). for example, when a new version of foo is available and we are trying to update all foo service-instances to the new version.

One way to solve this issue is by changing the AppDeploymentUpdateServiceInstanceWorkflow.accept method to reject service-instances without backing app or service (in failed state).

Another way would be handling the missing backing app / services gracefully during update.

@kvmw kvmw changed the title AppDeploymentUpdateServiceInstanceWorkflow is trying to update a service-instance without backing application or backing service. AppDeploymentUpdateServiceInstanceWorkflow is trying to update a service-instances without backing application or backing service. Feb 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant