Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Discovery properties does not respect user configuration #1225

Open
rmannibucau opened this issue Apr 4, 2023 · 0 comments
Open

Simple Discovery properties does not respect user configuration #1225

rmannibucau opened this issue Apr 4, 2023 · 0 comments

Comments

@rmannibucau
Copy link

Describe the bug
I expect environment variables to be usable to configure simple discovery.
The loop initializing the serviceId in the configured simple service properties breaks user config if done [1].
Is it possible to change this loop logic ([1]) to set the service id if not set and if set ensure the key is the serviceId configured and not the deduced one with spring env->properties mapping logic which is easily wrong if the services use iphen in the name.

Sample
Not sure it is needed.

[1] https://github.com/spring-cloud/spring-cloud-commons/blob/main/spring-cloud-commons/src/main/java/org/springframework/cloud/client/discovery/simple/SimpleDiscoveryProperties.java#L81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants