Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom metric's tag for MicrometerStatsLoadBalancerLifecycle #1258

Open
mario45211 opened this issue Aug 23, 2023 · 1 comment
Open

Custom metric's tag for MicrometerStatsLoadBalancerLifecycle #1258

mario45211 opened this issue Aug 23, 2023 · 1 comment

Comments

@mario45211
Copy link

Is your feature request related to a problem? Please describe.
I'm integrating Spring Cloud LoadBalancer with a Consul Discovery Client and I want to include own Consul's instance tags in metrics from Load Balancer.

Describe the solution you'd like
I'd like to register custom customizer bean, which could enrich micrometer's tags for load balancer metrics.

Describe alternatives you've considered
I've Implemented own LoadBalancerLifecycle to gather metrics only to add few tags, but it seems tedious, especially having mechanism in a MicrometerStatsLoadBalancerLifecycle class.

@OlgaMaciaszek
Copy link
Collaborator

Hello @mario45211, thanks for reporting the issue. I'm going to label it as enhancement, however, since it can be done by implementing the LoadBalancerLifecycle and we have not had more requests for this kind of feature, we might not give it high priority. Would you like to create a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants