Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints for spring-cloud-dataflow-rest-client Spring Boot 3 port #5862

Open
klopfdreh opened this issue Jul 8, 2024 · 0 comments
Open

Hints for spring-cloud-dataflow-rest-client Spring Boot 3 port #5862

klopfdreh opened this issue Jul 8, 2024 · 0 comments
Labels
for/team-attention For team attention

Comments

@klopfdreh
Copy link
Contributor

klopfdreh commented Jul 8, 2024

Problem description:
Currently we are trying to port our task applications to Spring Boot 3. Because we are using the spring-cloud-dataflow-rest-client in one of our task applications there are some binary incompatibilities as this package relies on Spring Boot dependencies. I already created a ticket to reduce dependencies: #5405.

To port the rest client I noticed two incompatibilities:

  1. VndErrorResponseErrorHandler uses org.springframework.http.client.ClientHttpResponse.getStatusCode() which returns a HttpStatusCode instead of a HttpStatus
  2. DataFlowClientAutoConfiguration uses OAuth2ClientPropertiesRegistrationAdapter with OAuth2ClientPropertiesRegistrationAdapter.getClientRegistrations(properties).values()) which can be replaced by OAuth2ClientPropertiesMapper with new OAuth2ClientPropertiesMapper(properties).asClientRegistrations().values()) see: https://github.com/spring-projects/spring-boot/wiki/Spring-Boot-3.1-Release-Notes#deprecations-in-spring-boot-310

Solution description:
N/A

Description of alternatives:
N/A

Additional context:
N/A

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Jul 8, 2024
@cppwfs cppwfs added for/team-attention For team attention and removed status/need-triage Team needs to triage and take a first look labels Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
for/team-attention For team attention
Projects
None yet
Development

No branches or pull requests

2 participants