Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support new Spring release train versioning and suffixes #193

Open
spencergibb opened this issue Apr 16, 2020 · 7 comments
Open

Support new Spring release train versioning and suffixes #193

spencergibb opened this issue Apr 16, 2020 · 7 comments

Comments

@spencergibb
Copy link
Member

spencergibb commented Apr 16, 2020

We are moving to calver with YYYY.MINOR.MICRO suffix for prereleases are -MX, -RCX. For release there is no longer a .RELEASE.

In ProjectVersionTests.should_return_true_for_a_valid_version() the following happens

then(projectVersion("2020.0.0-M1").isValid()).isTrue(); // success
then(projectVersion("2020.0.0-RC2").isValid()).isTrue(); // success
then(projectVersion("2020.0.0").isValid()).isTrue(); // failure
spencergibb added a commit that referenced this issue Apr 16, 2020
See gh-193 for failing 2020.0.0 (which is a GA release).
@spencergibb
Copy link
Member Author

spencergibb commented Apr 16, 2020

Also ProjectVersionTests.should_return_true_for_release_versions() fails for 2020.0.0.

Possible impl for ProjectVersion.isRelease()

	public boolean isRelease() {
		return this.version != null && (
				this.version.contains("RELEASE") ||
						(!isSnapshot() && !isMilestone() && !isRc())
		);
	}

also should_get_major_from_version() fails

@spencergibb
Copy link
Member Author

spencergibb commented Apr 16, 2020

ProjectVersionTests.should_return_true_for_service_release_versions() fails for 2020.0.1.

pseudo code

if (ends with SR\d || (isRelease() && 3rd component > 0))

@spencergibb
Copy link
Member Author

See also 3658fcc

@spencergibb
Copy link
Member Author

ProjectGitHandler.branchFromVersion() can't handle new suffixes 2020.0.0-M1

@marcingrzejszczak
Copy link
Collaborator

Added support for branch resolution via 0e3a95f

@spencergibb
Copy link
Member Author

Can this be closed?

@spencergibb
Copy link
Member Author

This is still a problem for at least release notes. It thinks the release train is 2020 when it should be 2020.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants