-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Invalid configuration is not fatal #685
Comments
PS. I know about fail-fast but spring.config.import has concept of optional and non-optional imports and these should be honored IMHO. |
Have you tried setting Generally, we could switch entirely on the built-in mechanism by throwing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
If configuration is invalid (e.g. wrong SSL certs) then vault config prints exception and continues execution.
Even when spring.config.import is not set to optional.
This is probably because in
LeaseAwareVaultPropertySource
ignoreSecretNotFound
is always true.Sample
bug-vault-bad-config-nonfatal.zip
Log
The text was updated successfully, but these errors were encountered: