Starters do not depend on spring-boot-starter

[wilkinsona]

As noted in the documentation starters are required to directly or indirectly depend upon spring-boot-starter. The starters in this repository do not meet this requirement so when they are used in isolation, things like @SpringBootApplication are not on the classpath.

[spencergibb]

Does it make sense to move this to spring cloud commons so there doesn't have to be an issue in every repo?

[wilkinsona]

Sorry, I'd assumed it was an isolated problem based on spring-io/start.spring.io#191. I thought we would have heard about it before if it applies to the Cloud starters that, I imagine, are more commonly used. I guess it's unusual to use one in isolation though?

If the problem's more widespread then, yeah, it probably makes sense to handle it centrally than have loads of issues. Whatever works best for you.

[spencergibb]

I'll investigate. The starters here depends on commons directly rather that spring cloud starter, that may be enough

[wilkinsona]

FWIW, spring-cloud-commons seems to be OK as spring-cloud-starter has the required dependency. spring-cloud-starter-config is fine too as it depends on spring-cloud-starter.

[spencergibb]

Yeah, not in front of computer to check efficiently, so it is likely localized.

[mbhave]

spring-cloud-starter-consul-config appears to be broken as well so maybe it's a broader problem. Projects generated with spring-cloud-starter-vault-config aren't broken as we explicitly mark that one as not a starter.

[snicoll]

Projects generated with spring-cloud-starter-vault-config aren't broken as we explicitly mark that one as not a starter.

It was a workaround until the definition of the starter got fixed. I thought I had created an issue back then but it looks like I forgot.

[wilkinsona]

Mark fixed the vault one a while ago so we needed to catch up. See spring-io/start.spring.io#193.

[snicoll]

I was about to write that, see spring-io/initializr#414 (comment)

[wilkinsona]

I'm in the process of writing some tests for start.spring.io to check that a dependency that is named like a starter actually is one. I've identified the following modules that should depend on spring-boot-starter but do not do so:

• spring-cloud-starter-aws
• spring-cloud-starter-aws-jdbc
• spring-cloud-starter-aws-messaging
• spring-cloud-starter-consul-config
• spring-cloud-starter-zookeeper-config

There may be others as the start.spring.io tests only cover the starters that are offered by the service.

spring-cloud-services-starter-config-client is also affected but I'll open a separate issue for that.