Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on spring-boot-testcontainers #4

Open
rwinch opened this issue Jan 4, 2024 · 0 comments
Open

Remove dependency on spring-boot-testcontainers #4

rwinch opened this issue Jan 4, 2024 · 0 comments

Comments

@rwinch
Copy link
Collaborator

rwinch commented Jan 4, 2024

Currently the project relies on TestcontainersPropertySource to create DynamicPropertyRegistry. The usage of TestcontainersPropertySource adds a dependency on spring-boot-testcontainers. This dependency does not make sense since users will likely want to use DynamicProperties without necessarily needing Testcontainers. We should see if this can be moved to a different package or consider copying the code to remove the unnecessary dependency on spring-boot-testcontainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant