-
Notifications
You must be signed in to change notification settings - Fork 860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove embedding from Document #1781
Comments
The |
The |
This PR #1822 addresses this. |
We need to review all the vector store impls and make appropriate modifications. I noticed the Neo4jVectorStore also uses the 'getEmbeddings' method as sort of simple data structure to pass things along while adding. It can be refactored. |
If possible, it would be great to get #1794 merged before start removing the "embedding" field, mostly to avoid many many merge conflicts since they touch the same code area 😅 |
Created #1826 to track this. |
This was a design decision way back taken from how langchain (python) was designed. In practice, this doesn't seem useful. It acts like a sort of cache, if you are writing the same document to the vector store multiple times, which doesn't seem realistic. If you have a use case for keeping the embedding in the Document, please comment.
The text was updated successfully, but these errors were encountered: