Parts not shown if we kill the application

[casperstorm]

If a user kills the application, or connection, we don't see the {user} has left the channel

[ineeee]

this makes sense because the client never sends a PART or QUIT to the server

[tarkah]

What's the expected behavior here? Does IRC mandate a client sends QUIT before exiting? I'd imagine the server will broadcast part / quit when the client loses connection to the server.

I'd imagine we only want to implement this if we add a configuration where user can specify a QUIT / PART message when exiting the application / leaving channels.

Edit: From IRC docs:

If a client connection is closed without the client issuing a QUIT command to the server, the server MUST distribute a QUIT message to other clients informing them of this, distributed in the same was an ordinary QUIT message. Servers MUST fill with a message reflecting the nature of the event which caused it to happen. For instance, "Ping timeout: 120 seconds", "Excess Flood", and "Too many connections from this IP" are examples of relevant reasons for closing or for a connection with a client to have been closed.

[ineeee]

the client doesn't/can't determine the quit message because the process is already dead by that point, so its up to the irc daemon.

edit: saw the above edit while sent this :p

[tarkah]

the client doesn't/can't determine the quit message because the process is already dead by that point, so its up to the irc daemon.

We actually capture the request to close the application and do some housecleaning... (flush history to disk, etc). So in theory we could send a QUIT from our client w/ a configurable message, if desired. This obv doesn't work if someone kills the running process vs graceful close.

[tarkah]

I'd imagine though that we should never send PART and only send QUIT as that is effectively a superset of PART. QUIT inherently means they have parted from all channels.

So I think the scope of this issue should be:

• Send QUIT when user closes the application. Allow for configuring the QUIT message otherwise it sends an empty reason.

[casperstorm]

Fixed by #109.
Opened #110 which continues the above discussion.