Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsVendor could be changed to use a single regexp #230

Open
smola opened this issue Jun 21, 2019 · 1 comment
Open

IsVendor could be changed to use a single regexp #230

smola opened this issue Jun 21, 2019 · 1 comment

Comments

@smola
Copy link
Contributor

smola commented Jun 21, 2019

IsVendor is using the substring library. It does an Or with dozens of Go regexps. Instead of that, we could check if using a single Go regexp with | is faster.

@bzz
Copy link
Contributor

bzz commented Jul 1, 2019

Thank you for a suggestion!

Indeed, we do exactly this kind of optimization in the latest-added heuristics strategy, but never actually got to measure the performance benefit of that.

Let me know if you are seeing IsVendor being slow in actual application and we'll gauge priority of this one!

@bzz bzz added the enhancement label Jul 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants