You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
IsVendor is using the substring library. It does an Or with dozens of Go regexps. Instead of that, we could check if using a single Go regexp with | is faster.
The text was updated successfully, but these errors were encountered:
Indeed, we do exactly this kind of optimization in the latest-added heuristics strategy, but never actually got to measure the performance benefit of that.
Let me know if you are seeing IsVendor being slow in actual application and we'll gauge priority of this one!
IsVendor is using the substring library. It does an Or with dozens of Go regexps. Instead of that, we could check if using a single Go regexp with
|
is faster.The text was updated successfully, but these errors were encountered: