-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Creating ts srcbook on windows #297
Comments
There's a few issues, a couple of spots not using path.join and the decoder is full of issues from windows using |
I'll keep debugging. If I can make it through the decoder I'll make a PR. |
If you end up needing help or have questions feel free to ping me Ben & Nick likely won't be checking on things until Monday |
+1 |
@WesBosman by the way if you're not in the Discord, that's a good place to have longer conversations about the bug / PR / questions. GitHub is fine too, but wanted to share in case you were interested. |
Hey @nichochar thanks! I've joined the discord. |
My recommendation for windows users like me is to install WSL or Windows Subsystem for Linux (WSL)(https://ubuntu.com/desktop/wsl). I expend a week trying to make the windows option to work and it did not. After installing WSL all the problems disappeared it. It runs perfect with WSL through the browser localhost in windows. |
When I boot up srcbook and click the button to create a typescript srcbook I get the following error on Windows.
This error led me to the
node_modules/@srcbook/api/dist/tsserver/tsserver.mjs
file. I noticed there was a call to spawn on line 37. If I add the optionshell: true,
to the spawn command then I don't get the error anymore.Now I'm able to create a typescript srcbook without generating an error. However when I start to type into the text area to create my typescript file I get another error. This error causes the local server to stop running.
I think this is an issue with the
TextEncoder / TextDecoder
innode_modules/@srcbook/api/dist/tsserver/messages.mjs
.I tried editing the carriage return char code thinking it was an issue with line endings in Windows but that didn't help.
I'm able to create javascript notebooks and run them without an issue. The issue only seems to happen with typescript notebooks.
The text was updated successfully, but these errors were encountered: