Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clab Redeploy Does Not Find Topology File #2378

Closed
andywhitaker opened this issue Jan 3, 2025 · 4 comments
Closed

Clab Redeploy Does Not Find Topology File #2378

andywhitaker opened this issue Jan 3, 2025 · 4 comments
Labels
bug Something isn't working

Comments

@andywhitaker
Copy link

If I issue a clab redeploy command without the -t option the redeploy command destroys the lab then errors and quits before redeploying:

vscode ➜ /Users/awhitaker/network_labs/eos_lab $ sudo clab redeploy
INFO[0000] Parsing & checking topology file: eos.clab.yml 
INFO[0000] Destroying lab: eos                          
INFO[0001] Removed container: eos-leaf1                 
INFO[0001] Removed container: eos-leaf3                 
INFO[0001] Removed container: eos-spine2                
INFO[0001] Removed container: eos-leaf2                 
INFO[0001] Removed container: eos-spine1                
INFO[0001] Removed container: eos-leaf4                 
INFO[0001] Removing containerlab host entries from /etc/hosts file 
INFO[0001] Removing ssh config for containerlab nodes   
INFO[0001] Containerlab v0.61.0 started                 
Error: provide a path to the clab topology file
vscode ➜ /Users/awhitaker/network_labs/eos_lab $

The behavior seems different than clab deploy which automatically finds the topology in the current folder if not specified.

The behavior I would imagine best for redeploy would be to re-provision the same topology file that was parsed during the clean-up phase. If this is expected behavior and not an issue I might suggest maybe an error before the destructive phase of the cleanup to alert a topology must be provided.

Thanks so much! Clab is great!

@hellt
Copy link
Member

hellt commented Jan 3, 2025

yeah, this looks like a bug

@hellt hellt added the bug Something isn't working label Jan 3, 2025
@andywhitaker
Copy link
Author

Thanks @hellt!

@hellt
Copy link
Member

hellt commented Jan 5, 2025

there is a beta build that should fix it

you can download a linux/amd64 binary from here https://github.com/srl-labs/containerlab/actions/runs/12620762736/artifacts/2387657578 if that matches your target env

@andywhitaker
Copy link
Author

I'm on Apple ARM but as a quick test I downloaded the amd64 version of your dood-slim image and ran with emulation then copied this new beta binary over the /usr/bin/containerlab included in the container and it now appears to redeploy correctly!

I'd say this looks solved to me! Thanks!!

@hellt hellt closed this as completed Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants