Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't error if network down? #4

Open
unhammer opened this issue Mar 20, 2017 · 2 comments
Open

don't error if network down? #4

unhammer opened this issue Mar 20, 2017 · 2 comments

Comments

@unhammer
Copy link

Emacs tells me Failed to update status for /tmp/foo: HTTP/1\.[01] \([0-9]\{3\}\) whenever I open my laptop, since there's a slight delay until wifi connects. I don't think this calls for an something as invasive as an error (which shows even if you haven't looked at a CI-tracked project in hours). How about a special ((string= status "status unavailable") (build-status--propertize "?" status)) or something like that?

@unhammer
Copy link
Author

https://github.com/unhammer/build-status/tree/async fixes this by making it all async

@sshaw
Copy link
Owner

sshaw commented Mar 23, 2017

Emacs tells me Failed to update status for /tmp/foo: HTTP/1.[01] ([0-9]{3}) whenever I open my laptop,

That's a bad error message that's caused by a failing search-forward-regexp. Fixed by 01bb9cc.

I don't think this calls for an something as invasive as an error

What's so invasive about it? I think it's important for one to know that a network error is preventing the build status from being updated.

How about a special ((string= status "status unavailable") (build-status--propertize "?" status))

In this context status is the value that would be returned by the (failing) HTTP call mentioned above. So this wouldn't work.

https://github.com/unhammer/build-status/tree/async fixes this by making it all async

I think async is the way to go in general, regardless of this error. I'll take a look at your branch shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants