Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag versions #36

Closed
kbsali opened this issue Dec 18, 2013 · 7 comments
Closed

Tag versions #36

kbsali opened this issue Dec 18, 2013 · 7 comments

Comments

@kbsali
Copy link

kbsali commented Dec 18, 2013

Hi,

seeing #35 i realized that there are not tags for quicktile. This would help upgrading/downgrading to specific version of the script.

@brettbatie created a new repo without forking this one to answer this (of course he could / should have checked out the specific commit).

Anyway, I forked and tagged the all the commits bumping the version constant, but unfortunately github does not allow PR for this kind of commits. So here are they are for you @ssokolow to add them :

git tag -a 0.1.3 b3bf0e25b350df4a9624f45993e0651b623a915c -m "0.1.3"
git tag -a 0.1.4 4c4415a84e84ebf9aa2f9f0afa6089f363ba8bab -m "0.1.4"
git tag -a 0.1.5 bb47e9b355ce5da66306f883642954a899f84853 -m "0.1.5"
git tag -a 0.1.6 f7978209bab75a705a436e6c556a69843741e5a8 -m "0.1.6"
git tag -a 0.2.0 87b3e2f4a7c35ad633a4a58ec710694d54d82f10 -m "0.2.0"
git tag -a 0.2.0.1 86b001d7d4d3cf799950f04cab328659d83f21d5 -m "0.2.0.1"
git tag -a 0.2.1 30857f9e79488a09fe67f13c44717f3b221bfaa3 -m "0.2.1"
git tag -a 0.2.2 0a69eb000f71fb36b2ed43c31fa2e25d3545a5c8 -m "0.2.2"

Thanks!

@ssokolow
Copy link
Owner

Thanks. I kept meaning to do that but, whenever I had time, I ended up fixing bugs instead.

I'm a little behind schedule today, so I can't even spare time to refresh my memory on tag-pushing, but I'll try to get to that tomorrow morning.

@kbsali
Copy link
Author

kbsali commented Dec 18, 2013

git push origin --tags

@ssokolow
Copy link
Owner

Yes but I also have to do a little bit of quality control and that'll take time I can't afford to spare today.

@ssokolow
Copy link
Owner

This is going to be a little more time-consuming than I thought. My quick QA check shows that your tags don't match up with my versioning.

Your tags assume retrospective versioning (0.x.y is every commit up to the version bump) while I've been doing anticipatory versioning (The 0.x.y "release" is the last commit where that version string is still in the source.)

...which means that, by my versioning, the 0.2.1 "release" is the commit immediately before the one you tagged as "0.2.2" and the "0.2.0.1" release is the commit immediately before the one you tagged as "0.2.1".

@kbsali
Copy link
Author

kbsali commented Dec 19, 2013

alright, that should not be too long to fix.
Let me try and get it done asap (ie. before tomorrow! :))

@kbsali
Copy link
Author

kbsali commented Dec 19, 2013

There you go :

git tag -af 0.1.3 4aa7bd35857ee7fb673ad7f2bc6f50bb29813e0e -m "0.1.3"
git tag -af 0.1.4 cc832a4309c40ca5a9ba549e1053bd4f20e83541 -m "0.1.4"
git tag -af 0.1.5 7a5bf6ffb2a70d557a736f516f08d70ea5f9af83 -m "0.1.5"
git tag -af 0.1.6 084a66b3e9b2e8211c5b81120b21de9b8e5a094c -m "0.1.6"
git tag -af 0.2.0 b5a360a6a593187328e5466a5223dbf6cc02e110 -m "0.2.0"
git tag -af 0.2.0.1 99596f3126f7e578da3ee3c2bdfb1cdd34278594 -m "0.2.0.1"
git tag -af 0.2.1 bdc8125bb456759563d298593db58dbc9470d396 -m "0.2.1"

I've done it on my fork : https://github.com/kbsali/quicktile/releases

@ssokolow
Copy link
Owner

There. Your 0.1.3 tag was off (it should have been on the initial commit but I can't remember whether I started versioning this late or couldn't figure out how to import from bzr at the time.) and I decided to prefix them with "v" to follow GitHub convention but it's done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants