From 80117efdc07fc10eec7563bdb62a6e4a7a4cee9c Mon Sep 17 00:00:00 2001 From: moshe-blox Date: Tue, 31 Oct 2023 17:51:40 +0200 Subject: [PATCH 1/8] fix: force start duties in `ValidatorRegistrationRunner` --- .gitlab-ci.yml | 6 +++--- protocol/v2/ssv/runner/validator_registration.go | 3 --- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index f296289e6e..d4f9410ee8 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -40,7 +40,7 @@ Build stage Docker image: - docker tag $IMAGE_NAME:$CI_COMMIT_SHA $DOCKER_REPO_INFRA_STAGE:$CI_COMMIT_SHA - $DOCKER_LOGIN_TO_INFRA_STAGE_REPO && docker push $DOCKER_REPO_INFRA_STAGE:$CI_COMMIT_SHA only: - - stage + - fix-validator-registration-duty-start Deploy nodes to stage: stage: deploy @@ -59,7 +59,7 @@ Deploy nodes to stage: # | Deploy SSV nodes | # +--------------------+ - .k8/stage/scripts/deploy-cluster-1--4.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT - - .k8/stage/scripts/deploy-cluster-5--8.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT + # - .k8/stage/scripts/deploy-cluster-5--8.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT # - .k8/stage/scripts/deploy-cluster-9--12.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT # - .k8/stage/scripts/deploy-cluster-13--16.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT # @@ -69,7 +69,7 @@ Deploy nodes to stage: # █▓▒░ Keep commented unless you're testing the bootnode ░▒▓█ # - .k8/stage/scripts/deploy-boot-nodes.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE 1000m 1000m only: - - stage + - fix-validator-registration-duty-start Deploy exporter to stage: stage: deploy diff --git a/protocol/v2/ssv/runner/validator_registration.go b/protocol/v2/ssv/runner/validator_registration.go index 68bc4351b8..935ca86eee 100644 --- a/protocol/v2/ssv/runner/validator_registration.go +++ b/protocol/v2/ssv/runner/validator_registration.go @@ -56,9 +56,6 @@ func NewValidatorRegistrationRunner( func (r *ValidatorRegistrationRunner) StartNewDuty(logger *zap.Logger, duty *spectypes.Duty) error { // Note: Unlike the other runners, this doesn't call BaseRunner.baseStartNewDuty because // that requires a QBFTController which ValidatorRegistrationRunner doesn't have. - if r.HasRunningDuty() { - return errors.New("already running duty") - } r.BaseRunner.baseSetupForNewDuty(duty) return r.executeDuty(logger, duty) } From ae33dc0422a7c843fd156d03f1ed31d1fcef9d32 Mon Sep 17 00:00:00 2001 From: moshe-blox Date: Tue, 31 Oct 2023 17:52:43 +0200 Subject: [PATCH 2/8] deploy --- .gitlab-ci.yml | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index d4f9410ee8..4f2cf4ba99 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -40,7 +40,7 @@ Build stage Docker image: - docker tag $IMAGE_NAME:$CI_COMMIT_SHA $DOCKER_REPO_INFRA_STAGE:$CI_COMMIT_SHA - $DOCKER_LOGIN_TO_INFRA_STAGE_REPO && docker push $DOCKER_REPO_INFRA_STAGE:$CI_COMMIT_SHA only: - - fix-validator-registration-duty-start + - stage Deploy nodes to stage: stage: deploy @@ -59,7 +59,7 @@ Deploy nodes to stage: # | Deploy SSV nodes | # +--------------------+ - .k8/stage/scripts/deploy-cluster-1--4.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT - # - .k8/stage/scripts/deploy-cluster-5--8.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT + - .k8/stage/scripts/deploy-cluster-5--8.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT # - .k8/stage/scripts/deploy-cluster-9--12.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT # - .k8/stage/scripts/deploy-cluster-13--16.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT # @@ -69,7 +69,7 @@ Deploy nodes to stage: # █▓▒░ Keep commented unless you're testing the bootnode ░▒▓█ # - .k8/stage/scripts/deploy-boot-nodes.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE 1000m 1000m only: - - fix-validator-registration-duty-start + - stage Deploy exporter to stage: stage: deploy @@ -166,7 +166,7 @@ Build prod Docker image: - $DOCKER_LOGIN_TO_INFRA_PROD_REPO && docker push $DOCKER_REPO_INFRA_PROD:$CI_COMMIT_SHA only: - - main + - fix-validator-registration-duty-start Deploy nodes to prod: stage: deploy @@ -207,7 +207,7 @@ Deploy nodes to prod: # - .k8/production/mainnet/scripts/deploy-boot-nodes.sh $DOCKER_REPO_INFRA_PROD $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_PROD blox-infra-prod kubernetes-admin@blox-infra-prod ssv.network $K8S_API_VERSION $PROD_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT_V3 $SSV_NODES_MEM_LIMIT_V3 only: - - main + - fix-validator-registration-duty-start Deploy exporter to prod: stage: deploy From 5e83ce9c2378c8411bc5b89da72bcc095df28f91 Mon Sep 17 00:00:00 2001 From: moshe-blox Date: Sun, 5 Nov 2023 14:40:35 +0200 Subject: [PATCH 3/8] update to spec PR --- go.mod | 5 ++++- go.sum | 4 ++-- protocol/v2/ssv/runner/runner.go | 5 +++-- protocol/v2/ssv/runner/validator_registration.go | 5 +---- protocol/v2/ssv/runner/voluntary_exit.go | 8 +------- 5 files changed, 11 insertions(+), 16 deletions(-) diff --git a/go.mod b/go.mod index b39d5e0cc9..35e0cc3b99 100644 --- a/go.mod +++ b/go.mod @@ -223,5 +223,8 @@ replace github.com/google/flatbuffers => github.com/google/flatbuffers v1.11.0 replace github.com/dgraph-io/ristretto => github.com/dgraph-io/ristretto v0.1.1-0.20211108053508-297c39e6640f -//TODO remove this replace when the following PR is merged https://github.com/bloxapp/eth2-key-manager/pull/100 +// TODO: remove this replace when the following PR is merged https://github.com/bloxapp/eth2-key-manager/pull/100 replace github.com/bloxapp/eth2-key-manager => github.com/bloxapp/eth2-key-manager v1.3.2-0.20231022162227-e2b8264a29a5 + +// TODO: remove this replace when the following PR is merged https://github.com/bloxapp/ssv-spec/pull +replace github.com/bloxapp/ssv-spec => github.com/GalRogozinski/ssv-spec v0.0.0-20231101193255-1b6c21fd491d diff --git a/go.sum b/go.sum index cf4040a7be..9cd032b805 100644 --- a/go.sum +++ b/go.sum @@ -17,6 +17,8 @@ github.com/CloudyKit/fastprinter v0.0.0-20200109182630-33d98a066a53/go.mod h1:+3 github.com/CloudyKit/jet/v3 v3.0.0/go.mod h1:HKQPgSJmdK8hdoAbKUUWajkHyHo4RaU5rMdUywE7VMo= github.com/DataDog/zstd v1.5.2 h1:vUG4lAyuPCXO0TLbXvPv7EB7cNK1QV/luu55UHLrrn8= github.com/DataDog/zstd v1.5.2/go.mod h1:g4AWEaM3yOg3HYfnJ3YIawPnVdXJh9QME85blwSAmyw= +github.com/GalRogozinski/ssv-spec v0.0.0-20231101193255-1b6c21fd491d h1:RyGnDTFcJt69UEU4O9dAya9kO5qreDHDkKFMhOIyedw= +github.com/GalRogozinski/ssv-spec v0.0.0-20231101193255-1b6c21fd491d/go.mod h1:zPJR7YnG5iZ6I0h6EzfVly8bTBXaZwcx4TyJ8pzYVd8= github.com/Joker/hpp v1.0.0/go.mod h1:8x5n+M1Hp5hC0g8okX3sR3vFQwynaX/UgSOM9MeBKzY= github.com/Shopify/goreferrer v0.0.0-20181106222321-ec9c9a553398/go.mod h1:a1uqRtAwp2Xwc6WNPJEufxJ7fx3npB4UV/JOLmbu5I0= github.com/Shopify/sarama v1.26.1/go.mod h1:NbSGBSSndYaIhRcBtY9V0U7AyH+x71bG668AuWys/yU= @@ -56,8 +58,6 @@ github.com/bits-and-blooms/bitset v1.7.0 h1:YjAGVd3XmtK9ktAbX8Zg2g2PwLIMjGREZJHl github.com/bits-and-blooms/bitset v1.7.0/go.mod h1:gIdJ4wp64HaoK2YrL1Q5/N7Y16edYb8uY+O0FJTyyDA= github.com/bloxapp/eth2-key-manager v1.3.2-0.20231022162227-e2b8264a29a5 h1:vjrMmMH15Bo0QF+228CuEZvCI+OuPyJRco82Gj/WyTI= github.com/bloxapp/eth2-key-manager v1.3.2-0.20231022162227-e2b8264a29a5/go.mod h1:cT+qAJfnAzNz9StFoHQ8xAkyU2eyEukd6xfxvcBWuZA= -github.com/bloxapp/ssv-spec v0.3.3 h1:iNomqWQjxDDQouHMjl27PmH1hUolJ4u8QQ+HX/TQQcg= -github.com/bloxapp/ssv-spec v0.3.3/go.mod h1:zPJR7YnG5iZ6I0h6EzfVly8bTBXaZwcx4TyJ8pzYVd8= github.com/bradfitz/go-smtpd v0.0.0-20170404230938-deb6d6237625/go.mod h1:HYsPBTaaSFSlLx/70C2HPIMNZpVV8+vt/A+FMnYP11g= github.com/btcsuite/btcd/btcec/v2 v2.3.2 h1:5n0X6hX0Zk+6omWcihdYvdAlGf2DfasC0GMf7DClJ3U= github.com/btcsuite/btcd/btcec/v2 v2.3.2/go.mod h1:zYzJ8etWJQIv1Ogk7OzpWjowwOdXY1W/17j2MW85J04= diff --git a/protocol/v2/ssv/runner/runner.go b/protocol/v2/ssv/runner/runner.go index 1fc2225e15..1a06df1e28 100644 --- a/protocol/v2/ssv/runner/runner.go +++ b/protocol/v2/ssv/runner/runner.go @@ -271,9 +271,10 @@ func (b *BaseRunner) hasRunningDuty() bool { } func (b *BaseRunner) ShouldProcessDuty(duty *spectypes.Duty) error { - if b.QBFTController.Height >= specqbft.Height(duty.Slot) { + // assume StartingDuty is not nil if state is not nil + if b.State != nil && b.State.StartingDuty.Slot >= duty.Slot { return errors.Errorf("duty for slot %d already passed. Current height is %d", duty.Slot, - b.QBFTController.Height) + b.State.StartingDuty.Slot) } return nil } diff --git a/protocol/v2/ssv/runner/validator_registration.go b/protocol/v2/ssv/runner/validator_registration.go index 935ca86eee..3232fdff3e 100644 --- a/protocol/v2/ssv/runner/validator_registration.go +++ b/protocol/v2/ssv/runner/validator_registration.go @@ -54,10 +54,7 @@ func NewValidatorRegistrationRunner( } func (r *ValidatorRegistrationRunner) StartNewDuty(logger *zap.Logger, duty *spectypes.Duty) error { - // Note: Unlike the other runners, this doesn't call BaseRunner.baseStartNewDuty because - // that requires a QBFTController which ValidatorRegistrationRunner doesn't have. - r.BaseRunner.baseSetupForNewDuty(duty) - return r.executeDuty(logger, duty) + return r.BaseRunner.baseStartNewDuty(logger, r, duty) } // HasRunningDuty returns true if a duty is already running (StartNewDuty called and returned nil) diff --git a/protocol/v2/ssv/runner/voluntary_exit.go b/protocol/v2/ssv/runner/voluntary_exit.go index 7eba30c616..b569f853cc 100644 --- a/protocol/v2/ssv/runner/voluntary_exit.go +++ b/protocol/v2/ssv/runner/voluntary_exit.go @@ -50,13 +50,7 @@ func NewVoluntaryExitRunner( } func (r *VoluntaryExitRunner) StartNewDuty(logger *zap.Logger, duty *spectypes.Duty) error { - // Note: Unlike the other runners, this doesn't call BaseRunner.baseStartNewDuty because - // that requires a QBFTController which VoluntaryExitRunner doesn't have. - if r.HasRunningDuty() { - return errors.New("already running duty") - } - r.BaseRunner.baseSetupForNewDuty(duty) - return r.executeDuty(logger, duty) + return r.BaseRunner.baseStartNewDuty(logger, r, duty) } // HasRunningDuty returns true if a duty is already running (StartNewDuty called and returned nil) From 493cdb199222c00a3694bfa75a954acfe4d76ced Mon Sep 17 00:00:00 2001 From: moshe-blox Date: Sun, 5 Nov 2023 14:41:40 +0200 Subject: [PATCH 4/8] revert gitlab --- .gitlab-ci.yml | 50 ++------------------------------------------------ 1 file changed, 2 insertions(+), 48 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 4f2cf4ba99..2faf940701 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,52 +42,6 @@ Build stage Docker image: only: - stage -Deploy nodes to stage: - stage: deploy - tags: - - blox-infra-stage - script: - - apk add bash - - export K8S_API_VERSION=$INFRA_STAGE_K8_API_VERSION - - export SSV_NODES_CPU_LIMIT=$STAGE_SSV_NODES_CPU_LIMIT - - export SSV_NODES_MEM_LIMIT=$STAGE_SSV_NODES_MEM_LIMIT - - curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.17.0/bin/linux/amd64/kubectl - - chmod 755 kubectl - - mv kubectl /usr/bin/ - # - # +--------------------+ - # | Deploy SSV nodes | - # +--------------------+ - - .k8/stage/scripts/deploy-cluster-1--4.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT - - .k8/stage/scripts/deploy-cluster-5--8.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT - # - .k8/stage/scripts/deploy-cluster-9--12.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT - # - .k8/stage/scripts/deploy-cluster-13--16.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT $SSV_NODES_MEM_LIMIT - # - # +-------------------+ - # │ Deploy Bootnode | - # +-------------------+ - # █▓▒░ Keep commented unless you're testing the bootnode ░▒▓█ - # - .k8/stage/scripts/deploy-boot-nodes.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $STAGE_HEALTH_CHECK_IMAGE 1000m 1000m - only: - - stage - -Deploy exporter to stage: - stage: deploy - tags: - - blox-infra-stage - script: - - apk add bash - - export K8S_API_VERSION=$INFRA_STAGE_K8_API_VERSION - - export SSV_EXPORTER_CPU_LIMIT=$STAGE_SSV_EXPORTER_CPU_LIMIT - - export SSV_EXPORTER_MEM_LIMIT=$STAGE_SSV_EXPORTER_MEM_LIMIT - - curl -LO https://storage.googleapis.com/kubernetes-release/release/v1.17.0/bin/linux/amd64/kubectl - - chmod 755 kubectl - - mv kubectl /usr/bin/ - - .k8/stage/scripts/deploy-exporters.sh $DOCKER_REPO_INFRA_STAGE $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_STAGE blox-infra-stage kubernetes-admin@blox-infra stage.ssv.network $K8S_API_VERSION $SSV_EXPORTER_CPU_LIMIT $SSV_EXPORTER_MEM_LIMIT - only: - - stage - - # +---------------------+ # | STAGE HETZNER NODES | # +---------------------+ @@ -166,7 +120,7 @@ Build prod Docker image: - $DOCKER_LOGIN_TO_INFRA_PROD_REPO && docker push $DOCKER_REPO_INFRA_PROD:$CI_COMMIT_SHA only: - - fix-validator-registration-duty-start + - main Deploy nodes to prod: stage: deploy @@ -207,7 +161,7 @@ Deploy nodes to prod: # - .k8/production/mainnet/scripts/deploy-boot-nodes.sh $DOCKER_REPO_INFRA_PROD $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_PROD blox-infra-prod kubernetes-admin@blox-infra-prod ssv.network $K8S_API_VERSION $PROD_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT_V3 $SSV_NODES_MEM_LIMIT_V3 only: - - fix-validator-registration-duty-start + - main Deploy exporter to prod: stage: deploy From b0a1cf5e7dad62bb5be578aae0487d983f60228d Mon Sep 17 00:00:00 2001 From: moshe-blox Date: Sun, 5 Nov 2023 15:11:38 +0200 Subject: [PATCH 5/8] fix spectest run --- protocol/v2/ssv/spectest/ssv_mapping_test.go | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/protocol/v2/ssv/spectest/ssv_mapping_test.go b/protocol/v2/ssv/spectest/ssv_mapping_test.go index 14fac24b35..fae52f8e21 100644 --- a/protocol/v2/ssv/spectest/ssv_mapping_test.go +++ b/protocol/v2/ssv/spectest/ssv_mapping_test.go @@ -175,11 +175,13 @@ func newRunnerDutySpecTestFromMap(t *testing.T, m map[string]interface{}) *Start require.NoError(t, json.Unmarshal(byts, duty)) outputMsgs := make([]*spectypes.SignedPartialSignatureMessage, 0) - for _, msg := range m["OutputMessages"].([]interface{}) { - byts, _ = json.Marshal(msg) - typedMsg := &spectypes.SignedPartialSignatureMessage{} - require.NoError(t, json.Unmarshal(byts, typedMsg)) - outputMsgs = append(outputMsgs, typedMsg) + if v, ok := m["OutputMessages"].([]interface{}); ok { + for _, msg := range v { + byts, _ = json.Marshal(msg) + typedMsg := &spectypes.SignedPartialSignatureMessage{} + require.NoError(t, json.Unmarshal(byts, typedMsg)) + outputMsgs = append(outputMsgs, typedMsg) + } } ks := testingutils.KeySetForShare(&spectypes.Share{Quorum: uint64(baseRunnerMap["Share"].(map[string]interface{})["Quorum"].(float64))}) From 21bb26e37fc85f4e467f34aa6d506f6ad5e7471b Mon Sep 17 00:00:00 2001 From: moshe-blox Date: Sun, 5 Nov 2023 16:05:28 +0200 Subject: [PATCH 6/8] update spec JSONs --- go.mod | 2 +- go.sum | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/go.mod b/go.mod index 35e0cc3b99..dd15d92b49 100644 --- a/go.mod +++ b/go.mod @@ -227,4 +227,4 @@ replace github.com/dgraph-io/ristretto => github.com/dgraph-io/ristretto v0.1.1- replace github.com/bloxapp/eth2-key-manager => github.com/bloxapp/eth2-key-manager v1.3.2-0.20231022162227-e2b8264a29a5 // TODO: remove this replace when the following PR is merged https://github.com/bloxapp/ssv-spec/pull -replace github.com/bloxapp/ssv-spec => github.com/GalRogozinski/ssv-spec v0.0.0-20231101193255-1b6c21fd491d +replace github.com/bloxapp/ssv-spec => github.com/moshe-blox/ssv-spec v0.0.0-20231105135956-a64e63f6e35a diff --git a/go.sum b/go.sum index 9cd032b805..4aabd85bc6 100644 --- a/go.sum +++ b/go.sum @@ -17,8 +17,6 @@ github.com/CloudyKit/fastprinter v0.0.0-20200109182630-33d98a066a53/go.mod h1:+3 github.com/CloudyKit/jet/v3 v3.0.0/go.mod h1:HKQPgSJmdK8hdoAbKUUWajkHyHo4RaU5rMdUywE7VMo= github.com/DataDog/zstd v1.5.2 h1:vUG4lAyuPCXO0TLbXvPv7EB7cNK1QV/luu55UHLrrn8= github.com/DataDog/zstd v1.5.2/go.mod h1:g4AWEaM3yOg3HYfnJ3YIawPnVdXJh9QME85blwSAmyw= -github.com/GalRogozinski/ssv-spec v0.0.0-20231101193255-1b6c21fd491d h1:RyGnDTFcJt69UEU4O9dAya9kO5qreDHDkKFMhOIyedw= -github.com/GalRogozinski/ssv-spec v0.0.0-20231101193255-1b6c21fd491d/go.mod h1:zPJR7YnG5iZ6I0h6EzfVly8bTBXaZwcx4TyJ8pzYVd8= github.com/Joker/hpp v1.0.0/go.mod h1:8x5n+M1Hp5hC0g8okX3sR3vFQwynaX/UgSOM9MeBKzY= github.com/Shopify/goreferrer v0.0.0-20181106222321-ec9c9a553398/go.mod h1:a1uqRtAwp2Xwc6WNPJEufxJ7fx3npB4UV/JOLmbu5I0= github.com/Shopify/sarama v1.26.1/go.mod h1:NbSGBSSndYaIhRcBtY9V0U7AyH+x71bG668AuWys/yU= @@ -521,6 +519,8 @@ github.com/modern-go/reflect2 v0.0.0-20180701023420-4b7aa43c6742/go.mod h1:bx2lN github.com/modern-go/reflect2 v1.0.1/go.mod h1:bx2lNnkwVCuqBIxFjflWJWanXIb3RllmbCylyMrvgv0= github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9Gz0M= github.com/mohae/deepcopy v0.0.0-20170929034955-c48cc78d4826 h1:RWengNIwukTxcDr9M+97sNutRR1RKhG96O6jWumTTnw= +github.com/moshe-blox/ssv-spec v0.0.0-20231105135956-a64e63f6e35a h1:I9d5JgkAFj3twwA3D7KkMxvp1wvMnkScmSGDvlf8J7o= +github.com/moshe-blox/ssv-spec v0.0.0-20231105135956-a64e63f6e35a/go.mod h1:zPJR7YnG5iZ6I0h6EzfVly8bTBXaZwcx4TyJ8pzYVd8= github.com/moul/http2curl v1.0.0/go.mod h1:8UbvGypXm98wA/IqH45anm5Y2Z6ep6O31QGOAZ3H0fQ= github.com/mr-tron/base58 v1.1.2/go.mod h1:BinMc/sQntlIE1frQmRFPUoPA1Zkr8VRgBdjWI2mNwc= github.com/mr-tron/base58 v1.1.3/go.mod h1:BinMc/sQntlIE1frQmRFPUoPA1Zkr8VRgBdjWI2mNwc= From 3d6494264eef0fe92b07d3699233fd92a73e9bdd Mon Sep 17 00:00:00 2001 From: moshe-blox Date: Sun, 5 Nov 2023 16:29:04 +0200 Subject: [PATCH 7/8] deploy to prater 1--4 --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 2faf940701..8055f7fb58 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -120,7 +120,7 @@ Build prod Docker image: - $DOCKER_LOGIN_TO_INFRA_PROD_REPO && docker push $DOCKER_REPO_INFRA_PROD:$CI_COMMIT_SHA only: - - main + - fix-validator-registration-duty-start Deploy nodes to prod: stage: deploy @@ -161,7 +161,7 @@ Deploy nodes to prod: # - .k8/production/mainnet/scripts/deploy-boot-nodes.sh $DOCKER_REPO_INFRA_PROD $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_PROD blox-infra-prod kubernetes-admin@blox-infra-prod ssv.network $K8S_API_VERSION $PROD_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT_V3 $SSV_NODES_MEM_LIMIT_V3 only: - - main + - fix-validator-registration-duty-start Deploy exporter to prod: stage: deploy From 129a5efd8413e2cd759e8ad299c80f3d1baafbeb Mon Sep 17 00:00:00 2001 From: Lior Rutenberg Date: Mon, 6 Nov 2023 18:20:37 +0200 Subject: [PATCH 8/8] revert gitlab ci --- .gitlab-ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 8055f7fb58..2faf940701 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -120,7 +120,7 @@ Build prod Docker image: - $DOCKER_LOGIN_TO_INFRA_PROD_REPO && docker push $DOCKER_REPO_INFRA_PROD:$CI_COMMIT_SHA only: - - fix-validator-registration-duty-start + - main Deploy nodes to prod: stage: deploy @@ -161,7 +161,7 @@ Deploy nodes to prod: # - .k8/production/mainnet/scripts/deploy-boot-nodes.sh $DOCKER_REPO_INFRA_PROD $CI_COMMIT_SHA ssv $APP_REPLICAS_INFRA_PROD blox-infra-prod kubernetes-admin@blox-infra-prod ssv.network $K8S_API_VERSION $PROD_HEALTH_CHECK_IMAGE $SSV_NODES_CPU_LIMIT_V3 $SSV_NODES_MEM_LIMIT_V3 only: - - fix-validator-registration-duty-start + - main Deploy exporter to prod: stage: deploy