From 2723198eb33dd8395f1a3280a4b173e075a6cfd1 Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Fri, 12 Jul 2024 14:44:04 +0200 Subject: [PATCH 1/4] chore: fix formatting of druid/versions.py --- druid/versions.py | 46 +++++++++++++++++++++++----------------------- 1 file changed, 23 insertions(+), 23 deletions(-) diff --git a/druid/versions.py b/druid/versions.py index e9c7245c2..3191920d8 100644 --- a/druid/versions.py +++ b/druid/versions.py @@ -1,25 +1,25 @@ versions = [ - { - "product": "26.0.0", - "java-base": "11", - "java-devel": "11", - "authorizer": "0.5.0" - }, - { - "product": "28.0.1", - # Java 17 should be fully supported as of 27.0.0 https://github.com/apache/druid/releases#27.0.0-highlights-java-17-support - # Did not work in a quick test due to reflection error: - # Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class - # java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError - "java-base": "11", - "java-devel": "11", - "authorizer": "0.5.0" - }, - { - "product": "30.0.0", - # https://druid.apache.org/docs/30.0.0/operations/java/ - "java-base": "17", - "java-devel": "17", - "authorizer": "0.5.0" - } + { + "product": "26.0.0", + "java-base": "11", + "java-devel": "11", + "authorizer": "0.5.0", + }, + { + "product": "28.0.1", + # Java 17 should be fully supported as of 27.0.0 https://github.com/apache/druid/releases#27.0.0-highlights-java-17-support + # Did not work in a quick test due to reflection error: + # Caused by: java.lang.reflect.InaccessibleObjectException: Unable to make protected final java.lang.Class + # java.lang.ClassLoader.defineClass(java.lang.String,byte[],int,int,java.security.ProtectionDomain) throws java.lang.ClassFormatError + "java-base": "11", + "java-devel": "11", + "authorizer": "0.5.0", + }, + { + "product": "30.0.0", + # https://druid.apache.org/docs/30.0.0/operations/java/ + "java-base": "17", + "java-devel": "17", + "authorizer": "0.5.0", + }, ] From d8a7e4b4f61aff876eef11eda990bce484decd5c Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Fri, 12 Jul 2024 14:45:22 +0200 Subject: [PATCH 2/4] chore: make a pre-release issue template Co-authored-by: Techassi --- .github/ISSUE_TEMPLATE/pre-release.md | 76 +++++++++++++++++++++++++++ 1 file changed, 76 insertions(+) create mode 100644 .github/ISSUE_TEMPLATE/pre-release.md diff --git a/.github/ISSUE_TEMPLATE/pre-release.md b/.github/ISSUE_TEMPLATE/pre-release.md new file mode 100644 index 000000000..ff99ed3b4 --- /dev/null +++ b/.github/ISSUE_TEMPLATE/pre-release.md @@ -0,0 +1,76 @@ +--- +name: Pre-Release Product Updates +about: This template can be used to track the product leading up to the next Stackable release +title: Release XX.(X)X +labels: ['epic'] +assignees: '' +--- + + + +## Product Updates for Stackable Release XX.(X)X + +> [!NOTE] +> Update the product versions based on what has been decided upon in the _Product Spreadsheet[^1]_. + +[^1]: Currently this is a private spreadsheet + +Replace the items in the task lists below with the applicable Pull Requests + + + +```[tasklist] +### Product Container Images +- [ ] https://github.com/stackabletech/docker-images/tree/main/airflow/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/druid/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/hadoop/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/hbase/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/hello-world/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/hive/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/java-base/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/java-devel/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/kafka/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/kafka-testing-tools/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/kcat/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/krb5/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/nifi/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/omid/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/opa/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/spark-k8s/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/stackable-base/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/superset/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/testing-tools/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/tools/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/trino/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/trino-cli/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/vector/versions.py +- [ ] https://github.com/stackabletech/docker-images/tree/main/zookeeper/versions.py +``` + +> [!NOTE] +> Generally you will only need to update the rust-toolchain version (`RUST_DEFAULT_TOOLCHAIN_VERSION`). + + + +```[tasklist] +### Other Container Images +- [ ] https://github.com/stackabletech/docker-images/tree/main/ubi8-rust-builder/Dockerfile +- [ ] https://github.com/stackabletech/docker-images/tree/main/ubi9-rust-builder/Dockerfile +``` From c019f11c81c6316150a1daf9e27ac9f80a052b5d Mon Sep 17 00:00:00 2001 From: Nick Date: Fri, 12 Jul 2024 15:00:21 +0200 Subject: [PATCH 3/4] Apply suggestions from code review Co-authored-by: Techassi --- .github/ISSUE_TEMPLATE/pre-release.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/pre-release.md b/.github/ISSUE_TEMPLATE/pre-release.md index ff99ed3b4..d2c741a82 100644 --- a/.github/ISSUE_TEMPLATE/pre-release.md +++ b/.github/ISSUE_TEMPLATE/pre-release.md @@ -1,7 +1,7 @@ --- -name: Pre-Release Product Updates -about: This template can be used to track the product leading up to the next Stackable release -title: Release XX.(X)X +name: Pre-Release Container Image Updates +about: This template can be used to track the container image updates leading up to the next Stackable release +title: "chore: Update Container Images for Stackable Release XX.(X)X" labels: ['epic'] assignees: '' --- @@ -11,7 +11,7 @@ assignees: '' This was created by an issue template: https://github.com/stackabletech/issues/issues/new/choose. --> -## Product Updates for Stackable Release XX.(X)X +## Container Image Updates for Stackable Release XX.(X)X > [!NOTE] > Update the product versions based on what has been decided upon in the _Product Spreadsheet[^1]_. From 1169377dbe49469351efb9969369e8ce08518062 Mon Sep 17 00:00:00 2001 From: Nick Larsen Date: Fri, 12 Jul 2024 16:30:15 +0200 Subject: [PATCH 4/4] ci: temporarily disable running across all file unitl druid/stackable/bin/run-druid is fixed --- .github/workflows/pr_pre-commit.yaml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.github/workflows/pr_pre-commit.yaml b/.github/workflows/pr_pre-commit.yaml index 2aeeb6d06..c4be523ca 100644 --- a/.github/workflows/pr_pre-commit.yaml +++ b/.github/workflows/pr_pre-commit.yaml @@ -13,3 +13,5 @@ jobs: with: python-version: '3.12' - uses: pre-commit/action@2c7b3805fd2a0fd8c1884dcaebf91fc102a13ecd # v3.0.1 + with: + extra_args: "" # Disable --all-files until we have time to fix druid/stackable/bin/run-druid